Print deprecation warning when using -jnlpUrl
#705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NotMyFault
approved these changes
Dec 8, 2023
timja
approved these changes
Dec 8, 2023
jenkinsci/jenkins#8773 prints a warning on the server side as well to increase the likelihood that this message is seen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that jenkinsci/jenkins#8639 and jenkinsci/jenkins-test-harness#670 have been shipping for a bit, time to deprecate this legacy usage mode.
Testing done
Verified that I could connect to the controller with the new calling convention without any warnings and that the warning was printed when using the old calling convention.