Print deprecation warning when using -jnlpUrl

[basil]

Upgrade to the latest release of Remoting, which prints this warning on the client side, and also add a similar warning on the server side as well to maximize the chances that the warning is actually seen by an administrator.

Testing done

Connected with -jnlpUrl and verified that the warning was printed on both the server and client side. Connected with -url and -name and verified that the warning was no longer printed on either the server or client side.

Proposed changelog entries

• The -jnlpUrl ${JENKINS_URL}/computer/${AGENT_NAME}/jenkins-agent.jnlp argument to the agent JAR has been deprecated; use -url ${JENKINS_URL} and -name ${AGENT_NAME} instead, potentially also passing in -webSocket, -tunnel, and/or work directory options as needed.

Proposed upgrade guidelines

• The -jnlpUrl ${JENKINS_URL}/computer/${AGENT_NAME}/jenkins-agent.jnlp argument to the agent JAR has been deprecated; use -url ${JENKINS_URL} and -name ${AGENT_NAME} instead, potentially also passing in -webSocket, -tunnel, and/or work directory options as needed. Official Docker images already use the new calling convention.

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[timja]

Nice!

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[pjwiseman]

The proposed (and implemented) changelog entries and warning does not mention the need to obtain a "secret" for connecting the agent, especially when using websockets. That "secret" used to be included in the jnlp file. The secret can now only be obtained by running a script, and only administrators can run scripts through a rest api. There needs to be a mechanism where the secret can be obtained programmatically (via the rest api) by a user with Agent Create or Agent Connect permissions.

jenkins.model.Jenkins.getInstance().getComputer("{node.name}").getJnlpMac()

[daniel-beck]

@pjwiseman

The secret can now only be obtained by running a script, and only administrators can run scripts through a rest api.

Alternatively, navigate to /computer/agentnamehere/ and copy it from one of the examples there.

There needs to be a mechanism where the secret can be obtained programmatically (via the rest api) by a user with Agent Create or Agent Connect permissions.

I suggest you file a feature request in the issue tracker.

[pjwiseman]

@daniel-beck Thanks for the push. Feature request raised.
https://issues.jenkins.io/browse/JENKINS-73735