Skip to content

Conversation

@stuartrowe
Copy link
Contributor

Fixes #794.

Use StatusAndTiming#findWorstWarningBetween to inform the status of branches while a build is still running.

Detection of WarningActions in enclosed nodes is the most reliable way to determine a status for stage or parallel branches. Previously StatusAndTiming#findWorstWarningBetween was only considered for completed pipelines.

Testing done

TODO: I will need to implement a test utility to gather the status of stages and parallel branches for a running pipeline. Currently this is only supported in StagesAndParallelBranchesVisitor for completed pipelines.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@stuartrowe stuartrowe requested a review from a team as a code owner May 31, 2025 14:27
@stuartrowe
Copy link
Contributor Author

Migrated from jenkinsci/pipeline-graph-analysis-plugin#170

@timja timja added the bug Something isn't working label May 31, 2025
@timja
Copy link
Member

timja commented May 31, 2025

Looks good, are you planning to add a test for it?

@stuartrowe
Copy link
Contributor Author

I'm going to try 😄

@timja
Copy link
Member

timja commented May 31, 2025

I'm going to try 😄

Wouldn’t you just need to put a milestone in and not pass it until verified?

@timja timja merged commit de72dc2 into jenkinsci:main Jun 1, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Caught stage failures in parallel stages gets green until the build finishes

2 participants