Caught stage failures in parallel stages gets green until the build finishes

[felipecrs]

Jenkins and plugins versions report

N/A

What Operating System are you using (both controller, and any agents involved in the problem)?

N/A

Reproduction steps

pipeline {
    agent any

    stages {
        stage('Tests') {
            parallel {
                stage('Failure caught') {
                    steps {
                        catchError(buildResult: 'SUCCESS', catchInterruptions: false, stageResult: 'FAILURE') {
                            sh 'exit 1'
                        }
                    }
                }
                stage('Fails') {
                    steps {
                        sh 'exit 1'
                    }
                }
                stage('Passes') {
                    steps {
                        sh 'sleep 10s'
                    }
                }
            }
        }
    }
}

See the video too.

Expected Results

To be marked as red as soon as it is marked as failed, like happens with sequential stages.

Actual Results

chrome_yBOHqWzp0e.mp4

Anything else?

Note this issue also happens in Blue Ocean:

chrome_YUhVM4KjZH.mp4

But I have no expectation this will be ever fixed there.

This issue is very relevant for me because I have a pipeline which runs other pipelines in parallel and some of them take 5 hours. If one of them fail early, it's shown as passing until the longest one finishes, which is very misleading and I have to teach my developers against it.

Are you interested in contributing a fix?

No response

[stuartrowe]

This is probably a bug in pipeline-graph-analysis-plugin's StatusAndTiming#computeBranchStatuses2(...) method. There is some special logic for running builds StatusAndTiming#computeChunkStatus2(...) that should be looked into first.

[stuartrowe]

jenkinsci/pipeline-graph-analysis-plugin#170 should fix it. However the maintainers of pipeline-graph-analysis-plugin encouraged us to port its implementations into pipeline-graph-view-plugin previously (jenkinsci/pipeline-graph-analysis-plugin#164 (comment))

[felipecrs]

I confirmed the fix in my production Jenkins too. Thank you so much, @stuartrowe!