Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to new build symbols (requires 2.434) #183

Merged
merged 7 commits into from
May 23, 2024
Merged

Conversation

timja
Copy link
Member

@timja timja commented Dec 10, 2023

Fixes jenkinsci/dark-theme-plugin#399

Testing done

Created a few matrix projects.

Tested nobuild, aborted, success.
Icons all look good (better than before as there was some rendering issues previously with text too close to icons)

image image image image image

Submitter checklist

Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looks nice so far

@Pesa
Copy link

Pesa commented Mar 16, 2024

ping?

@timja
Copy link
Member Author

timja commented Mar 16, 2024

@NotMyFault
Copy link
Member

Anything we are waiting for in particular? 👀

@timja
Copy link
Member Author

timja commented Apr 12, 2024

Nothing I’m aware of. I updated it to LTS release in case that’s what held back a merge before

@Pesa
Copy link

Pesa commented Apr 28, 2024

bump

@timja timja requested a review from a team April 28, 2024 20:37
pom.xml Outdated Show resolved Hide resolved
@basil basil merged commit 7eada56 into jenkinsci:master May 23, 2024
13 checks passed
@timja timja deleted the new-icon branch May 23, 2024 18:06
@lupalby
Copy link

lupalby commented May 30, 2024

Not entirely sure, but there is a chance that this PR or something related to this is breaking icons and clickable links in the matrix after the update to the latest Jenkins LTS. Others and I are affected: https://issues.jenkins.io/browse/JENKINS-73225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Aborted" icon is almost invisible
6 participants