Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Aborted" icon is almost invisible #399

Closed
Pesa opened this issue Sep 13, 2023 · 7 comments · Fixed by jenkinsci/matrix-project-plugin#183
Closed

"Aborted" icon is almost invisible #399

Pesa opened this issue Sep 13, 2023 · 7 comments · Fixed by jenkinsci/matrix-project-plugin#183
Labels
bug Something isn't working plugin-compatibility Issues with plugin compatibility

Comments

@Pesa
Copy link

Pesa commented Sep 13, 2023

Jenkins and plugins versions report

Environment
Jenkins: 2.423
OS: Linux - 5.10.0-25-amd64
Java: 17.0.7 - Debian (OpenJDK 64-Bit Server VM)
---
analysis-model-api:11.7.0
ansicolor:1.0.4
antisamy-markup-formatter:162.v0e6ec0fcfcf6
apache-httpcomponents-client-4-api:4.5.14-208.v438351942757
bootstrap5-api:5.3.0-1
bouncycastle-api:2.29
branch-api:2.1128.v717130d4f816
build-monitor-plugin:1.14-745.ve2023a_305f40
build-time-blame:70.v5031def3c2e3-2.1.0
build-timeout:1.31
caffeine-api:3.1.8-133.v17b_1ff2e0599
checks-api:2.0.1
cloudbees-folder:6.848.ve3b_fd7839a_81
code-coverage-api:4.7.0
command-launcher:107.v773860566e2e
commons-lang3-api:3.13.0-62.v7d18e55f51e2
commons-text-api:1.10.0-78.v3e7b_ea_d5a_fe1
configuration-as-code:1700.v6f448841296e
credentials:1271.v54b_1c2c6388a_
credentials-binding:631.v861c06d062b_4
dark-theme:372.v79b_02c754b_29
dashboard-view:2.495.v07e81500c3f2
data-tables-api:1.13.5-1
disk-usage:1.2
display-url-api:2.3.9
dtkit-api:3.0.2
durable-task:523.va_a_22cf15d5e0
echarts-api:5.4.0-5
embeddable-build-status:412.v09da_db_1dee68
font-awesome-api:6.4.0-2
forensics-api:2.3.0
gerrit-trigger:2.39.3
git:5.2.0
git-client:4.4.0
git-forensics:2.0.0
google-login:1.8
gradle:2.8.2
htmlpublisher:1.32
instance-identity:173.va_37c494ec4e5
ionicons-api:56.v1b_1c8c49374e
jackson2-api:2.15.2-350.v0c2f3f8fc595
jakarta-activation-api:2.0.1-3
jakarta-mail-api:2.0.1-3
javadoc:243.vb_b_503b_b_45537
javax-activation-api:1.2.0-6
javax-mail-api:1.6.2-9
jaxb:2.3.8-1
jdk-tool:73.vddf737284550
job-dsl:1.85
jquery3-api:3.7.0-1
junit:1217.v4297208a_a_b_ce
keyboard-shortcuts-plugin:1.4
mailer:463.vedf8358e006b_
material-theme:0.5.2-rc100.6121925fe229
matrix-auth:3.2
matrix-project:808.v5a_b_5f56d6966
metrics:4.2.18-442.v02e107157925
mina-sshd-api-common:2.10.0-69.v28e3e36d18eb_
mina-sshd-api-core:2.10.0-69.v28e3e36d18eb_
pam-auth:1.10
pipeline-build-step:505.v5f0844d8d126
pipeline-graph-analysis:202.va_d268e64deb_3
pipeline-graph-view:198.v0844db_6ca_554
pipeline-groovy-lib:685.v8ee9ed91d574
pipeline-input-step:477.v339683a_8d55e
pipeline-milestone-step:111.v449306f708b_7
pipeline-model-api:2.2144.v077a_d1928a_40
pipeline-model-definition:2.2144.v077a_d1928a_40
pipeline-model-extensions:2.2144.v077a_d1928a_40
pipeline-rest-api:2.33
pipeline-stage-step:305.ve96d0205c1c6
pipeline-stage-tags-metadata:2.2144.v077a_d1928a_40
pipeline-utility-steps:2.16.0
plain-credentials:143.v1b_df8b_d3b_e48
plugin-util-api:3.3.0
prism-api:1.29.0-7
role-strategy:689.v731678c3e0eb_
scm-api:676.v886669a_199a_a_
script-security:1275.v23895f409fb_d
snakeyaml-api:2.2-111.vc6598e30cc65
solarized-theme:0.1
ssh-credentials:308.ve4497b_ccd8f4
ssh-slaves:2.916.vd17b_43357ce4
sshd:3.312.v1c601b_c83b_0e
structs:325.vcb_307d2a_2782
theme-manager:215.vc1ff18d67920
timestamper:1.26
token-macro:384.vf35b_f26814ec
trilead-api:2.84.v72119de229b_7
variant:60.v7290fc0eb_b_cd
versioncolumn:162.v85841b_0790d5
warnings-ng:10.4.0
workflow-aggregator:596.v8c21c963d92d
workflow-api:1275.veb_e0969ddf9e
workflow-basic-steps:1042.ve7b_140c4a_e0c
workflow-cps:3787.v8f5dcd14a_fa_c
workflow-durable-task-step:1289.v4d3e7b_01546b_
workflow-job:1346.v180a_63f40267
workflow-multibranch:756.v891d88f2cd46
workflow-scm-step:415.v434365564324
workflow-step-api:639.v6eca_cd8c04a_a_
workflow-support:865.v43e78cc44e0d
xunit:3.1.3

What Operating System are you using (both controller, and any agents involved in the problem)?

Linux

Reproduction steps

  1. Abort a running build

Expected Results

All icons should be visible.

Actual Results

"Aborted" icon is very hard to see against the dark background.

Screenshot 2023-09-12 at 9 23 13 PM

Anything else?

No response

@Pesa Pesa added the bug Something isn't working label Sep 13, 2023
@janfaracik
Copy link
Contributor

Fixed in core Jenkins with jenkinsci/jenkins#8705 (review).

@timja timja closed this as completed Dec 10, 2023
@Pesa
Copy link
Author

Pesa commented Dec 10, 2023

Fixed in core Jenkins with jenkinsci/jenkins#8705 (review).

Almost... I can see the new icons (which are indeed much better!) on the dashboard and build history widget, but not on the job/build pages, the old icons are still used there.

New icons in build history:
Screenshot 2023-12-10 at 2 29 57 PM

Old icons in individual build page:
Screenshot 2023-12-10 at 2 30 43 PM

@timja timja reopened this Dec 10, 2023
@timja
Copy link
Member

timja commented Dec 10, 2023

Any steps to reproduce? That might be a plugin, or what type of job is that?

@Pesa
Copy link
Author

Pesa commented Dec 10, 2023

Good question. That's a matrix project according to the config:

<matrix-project plugin="[email protected]_e657db_924">

So is this a plugin bug?

@timja
Copy link
Member

timja commented Dec 10, 2023

Yes although if it had been noticed when the change was being done it would have been done at the same time

@timja
Copy link
Member

timja commented Dec 10, 2023

I've raised a PR to fix it in the plugin:
jenkinsci/matrix-project-plugin#183

@Pesa
Copy link
Author

Pesa commented Dec 10, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working plugin-compatibility Issues with plugin compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants