Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip LogRotatorTest#ableToDeleteCurrentBuild on Windows #9923

Merged
merged 2 commits into from
Nov 2, 2024
Merged

Skip LogRotatorTest#ableToDeleteCurrentBuild on Windows #9923

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f6d0dc
Skip `LogRotatorTest#ableToDeleteCurrentBuild` on Windows
dwnusbaum Oct 28, 2024
64bcbf3
Also remove BuildWatcher from LogRotatorTest in case it was contribut…
dwnusbaum Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions test/src/test/java/hudson/tasks/LogRotatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@
import static org.junit.Assert.assertNotNull;
import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assume.assumeFalse;

import hudson.Functions;
import hudson.Launcher;
import hudson.model.AbstractBuild;
import hudson.model.BuildListener;
Expand All @@ -50,10 +52,8 @@
import java.util.concurrent.TimeoutException;
import java.util.logging.Level;
import java.util.logging.Logger;
import org.junit.ClassRule;
import org.junit.Rule;
import org.junit.Test;
import org.jvnet.hudson.test.BuildWatcher;
import org.jvnet.hudson.test.FailureBuilder;
import org.jvnet.hudson.test.Issue;
import org.jvnet.hudson.test.JenkinsRule;
Expand All @@ -64,9 +64,6 @@
*/
public class LogRotatorTest {

@ClassRule
public static BuildWatcher watcher = new BuildWatcher();

@Rule
public JenkinsRule j = new JenkinsRule();

Expand Down Expand Up @@ -103,6 +100,8 @@ public void successVsFailureWithRemoveLastBuild() throws Exception {

@Test
public void ableToDeleteCurrentBuild() throws Exception {
assumeFalse("Deleting the current build while is is completing does not work consistently on Windows",
Functions.isWindows());
var p = j.createFreeStyleProject();
// Keep 0 builds, i.e. immediately delete builds as they complete.
LogRotator logRotator = new LogRotator(-1, 0, -1, -1);
Expand Down
Loading