Skip LogRotatorTest#ableToDeleteCurrentBuild
on Windows
#9923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to fix another observed flake from #9810, see https://github.com/jenkinsci/jenkins/pull/9810/files/9aaa7ba3fe523c07a4ed8d63281dbe86db064465#r1819518792.
Testing done
I ran these tests manually a little bit to check various things, but I do not have easy access to Windows to run the tests in a loop to check flakiness in a robust way. The observed failure is due to log rotation failing to delete a build with this exception:
My best hypothesis is that the move failed because something else was accessing the directory in question, but given the
AccessDeniedException
that did not have the typicalThe process cannot access the file because it is being used by another process
message, perhaps the problem was something else entirely.Proposed changelog entries
N/A
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist