Update appearance of 'Jenkins is starting' pages #9707

janfaracik · 2024-09-08T12:44:17Z

This PR updates the appearance of the 'Jenkins is starting' pages. The pages are now slightly more padded, content has been refined, use the <l:spinner/> component (rather than a custom one) and have a soft animation on load.

Booting

Before

After

Safe restart

Before

After

Restart

Before

After

⚠️ Unsure of how to access core/src/main/resources/hudson/lifecycle/WindowsInstallerLink/_restart.jelly

Testing done

Pages appear as expected

Proposed changelog entries

Update appearance of 'Jenkins is starting' pages.

Proposed upgrade guidelines

N/A

Submitter checklist

Give feedback

The Jira issue, if it exists, is well-described.
The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
There is automated testing or an explanation as to why this change has no tests.
New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
For dependency updates, there are links to external changelogs and, if possible, full differentials.
For new APIs and extension points, there is a link to at least one consumer.
Options

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Give feedback

There are at least two (2) approvals for the pull request and no outstanding requests for change.
Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
Proper changelog labels are set so that the changelog can be generated automatically.
If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
Options

janfaracik · 2024-09-08T12:51:02Z

/label web-ui

timja · 2024-09-08T12:57:48Z

You can do:

/label web-ui,rfe
/reviewer @jenkinsci/sig-ux

comment-ops-bot · 2024-09-08T12:57:51Z

I wasn't able to request review for the following reviewer(s): jenkinsci/sig-ux

Check that the reviewer is spelt right and try again.

timja · 2024-09-08T12:58:08Z

/reviewer @jenkinsci/sig-ux

timja · 2024-09-08T16:00:12Z

core/src/main/resources/hudson/util/HudsonIsRestarting/index_de.properties

@@ -1,5 +1,5 @@
 Please\ wait\ while\ Jenkins\ is\ restarting=Jenkins wird neu gestartet. Bitte warten.


When changing the English text we should update / remove translations.

e.g. here I think you would drop the Bitte warten

I can confirm, it should be "Jenkins wird neu gestartet"

Suggested change

Please\ wait\ while\ Jenkins\ is\ restarting=Jenkins wird neu gestartet. Bitte warten.

Please\ wait\ while\ Jenkins\ is\ restarting=Jenkins wird neu gestartet

Should the "." be part of the text or not?

timja · 2024-09-09T10:50:02Z

core/src/main/resources/hudson/util/HudsonIsLoading/index_pt_BR.properties

@@ -21,5 +21,5 @@
 # THE SOFTWARE.

 Please\ wait\ while\ Jenkins\ is\ getting\ ready\ to\ work=Por favor aguarde enquanto o Jenkins se prepara para trabalhar


This needs updating still (capturing as outstanding)

Done, updated the translations that I could, removed those that I couldn't

timja

LGTM

timja · 2024-09-10T09:22:54Z

core/src/main/resources/hudson/util/HudsonIsRestarting/index_da.properties

@@ -20,5 +20,5 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 # THE SOFTWARE.

-Your\ browser\ will\ reload\ automatically\ when\ Jenkins\ is\ ready.=Din browser vil genindlæse siden automatisk når Jenkins er klar.
+Your\ browser\ will\ reload\ automatically\ when\ Jenkins\ is\ ready=Din browser vil genindlæse siden automatisk når Jenkins er klar.
 Please\ wait\ while\ Jenkins\ is\ restarting=Vent venligst imens Jenkins genstarter


there's still a number of translations outstanding for this one Please\ wait\ while\ Jenkins\ is\ restarting

Either update or remove translation please

More translations outstanding

timja

LGTM thanks!

timja · 2024-09-11T20:50:11Z

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

daniel-beck · 2024-09-11T21:03:24Z

core/src/main/resources/hudson/util/HudsonIsLoading/index.jelly

+                        <l:spinner text="${%Please wait while Jenkins is getting ready to work}" />
+                    </h1>
+                    <p class="restarting">
+                        ${%Your browser will reload automatically when Jenkins is ready}


Why remove the trailing period? The other line is (or was) a title so didn't need it, but this one isn't.

Personal preference, I don't personally see the value of them for things like this. Would be a good thing to standardise across Jenkins, as right now many fields include periods, many don't.

For this piece of text in particular, it's centered and I think it appears more visually balanced without the punctuation.

many fields include periods, many don't

Are there many sentences that don't have periods?

MarkEWaite

Worked well in my interactive testing

daniel-beck · 2024-10-29T09:11:32Z

core/src/main/resources/hudson/util/HudsonIsRestarting/index_da.properties

@@ -20,5 +20,5 @@
 # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 # THE SOFTWARE.

-Your\ browser\ will\ reload\ automatically\ when\ Jenkins\ is\ ready.=Din browser vil genindlæse siden automatisk når Jenkins er klar.
-Please\ wait\ while\ Jenkins\ is\ restarting=Vent venligst imens Jenkins genstarter


Was this intentional? I don't speak the language but Google Translate says it's now "Please wait Jenkins restarts" which seems not great translated back.

janfaracik added 8 commits August 5, 2024 11:02

Init

fbcd08e

Merge branch 'master' into updated-startup-restart

91c9828

Merge branch 'master' into updated-startup-restart

b65280e

Update simple-page.scss

eea8cc9

Simplify

29eec13

Update simple-page.scss

e3192f8

Delete loading.css

1b47727

Merge branch 'master' into updated-startup-restart

40c528d

comment-ops-bot bot added the web-ui The PR includes WebUI changes which may need special expertise label Sep 8, 2024

comment-ops-bot bot added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Sep 8, 2024

comment-ops-bot bot requested a review from a team September 8, 2024 12:58

timja reviewed Sep 8, 2024

View reviewed changes

Update some translations

3bc89a7

timja reviewed Sep 9, 2024

View reviewed changes

janfaracik added 2 commits September 9, 2024 15:36

Remove some translations (still more to update)

a7bf7d5

WIP translations - just need to confirm with friends

9c2c99e

janfaracik changed the title ~~Updated appearance of 'Jenkins is starting' pages~~ Update appearance of 'Jenkins is starting' pages Sep 9, 2024

Merge branch 'master' into updated-startup-restart

9da1af4

timja previously approved these changes Sep 10, 2024

View reviewed changes

timja requested a review from a team September 10, 2024 08:01

timja reviewed Sep 10, 2024

View reviewed changes

Update/remove translations

cc58979

timja approved these changes Sep 11, 2024

View reviewed changes

StefanSpieker approved these changes Sep 11, 2024

View reviewed changes

comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Sep 11, 2024

daniel-beck reviewed Sep 11, 2024

View reviewed changes

janfaracik added 2 commits September 11, 2024 22:16

Merge branch 'master' into updated-startup-restart

b9056df

Merge branch 'master' into updated-startup-restart

b18a0d4

MarkEWaite approved these changes Sep 13, 2024

View reviewed changes

MarkEWaite self-assigned this Sep 13, 2024

timja merged commit ce3d8c1 into jenkinsci:master Sep 13, 2024
16 checks passed

timja deleted the updated-startup-restart branch September 13, 2024 06:42

daniel-beck reviewed Oct 29, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update appearance of 'Jenkins is starting' pages #9707

Update appearance of 'Jenkins is starting' pages #9707

janfaracik commented Sep 8, 2024 •

edited by MarkEWaite

Loading

Submitter checklist

Maintainer checklist

janfaracik commented Sep 8, 2024

timja commented Sep 8, 2024 •

edited

Loading

comment-ops-bot bot commented Sep 8, 2024

timja commented Sep 8, 2024

timja Sep 8, 2024

uhafner Sep 10, 2024

timja Sep 10, 2024 •

edited

Loading

uhafner Sep 10, 2024

timja Sep 9, 2024

janfaracik Sep 9, 2024

timja left a comment

timja Sep 10, 2024

timja left a comment

timja commented Sep 11, 2024

daniel-beck Sep 11, 2024

janfaracik Sep 11, 2024 •

edited

Loading

daniel-beck Sep 16, 2024

MarkEWaite left a comment

daniel-beck Oct 29, 2024

		@@ -1,5 +1,5 @@
		Please\ wait\ while\ Jenkins\ is\ restarting=Jenkins wird neu gestartet. Bitte warten.

		@@ -21,5 +21,5 @@
		# THE SOFTWARE.

		Please\ wait\ while\ Jenkins\ is\ getting\ ready\ to\ work=Por favor aguarde enquanto o Jenkins se prepara para trabalhar

Update appearance of 'Jenkins is starting' pages #9707

Update appearance of 'Jenkins is starting' pages #9707

Conversation

janfaracik commented Sep 8, 2024 • edited by MarkEWaite Loading

Booting

Safe restart

Restart

Testing done

Proposed changelog entries

Proposed upgrade guidelines

Submitter checklist

Desired reviewers

Maintainer checklist

janfaracik commented Sep 8, 2024

timja commented Sep 8, 2024 • edited Loading

comment-ops-bot bot commented Sep 8, 2024

timja commented Sep 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timja Sep 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timja left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

timja left a comment

Choose a reason for hiding this comment

timja commented Sep 11, 2024

Choose a reason for hiding this comment

janfaracik Sep 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarkEWaite left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

janfaracik commented Sep 8, 2024 •

edited by MarkEWaite

Loading

timja commented Sep 8, 2024 •

edited

Loading

timja Sep 10, 2024 •

edited

Loading

janfaracik Sep 11, 2024 •

edited

Loading