Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align font weights and font sizes #9393

Merged
merged 7 commits into from
Jun 24, 2024

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jun 14, 2024

Another small one to align font weights and font sizes, similar to #9367 #9366 #9365.

This MR largely decreases the weight of fonts across Jenkins, ideally increasing legibility and making Jenkins appear more consistent. Font sizes are also adjusted, aligning with whole pixels.

I'll annotate the MR with before/after screenshots.

Testing done

  • Jenkins appears as expected

Proposed changelog entries

  • Align font weights and font sizes.

Proposed upgrade guidelines

N/A

Submitter checklist

Preview Give feedback

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Preview Give feedback

@@ -197,7 +197,7 @@ $semantics: (
--link-text-decoration: none;
--link-text-decoration--hover: underline;
--link-text-decoration--active: underline;
--link-font-weight: 500;
--link-font-weight: 450;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
image

After
image

@@ -39,7 +39,7 @@ $semantics: (
--font-size-base: 1rem; // 16px
--font-size-sm: 0.875rem; // 14px
--font-size-xs: 0.75rem; // 12px
--font-size-monospace: 0.95em;
--font-size-monospace: 1em;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
image

After
image

@@ -155,7 +155,7 @@ pre {
background-color: var(--pre-background);
color: var(--pre-color);
font-family: var(--font-family-mono);
font-weight: 500;
font-weight: 400;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -19,8 +19,8 @@ $jenkins-dialog-padding: 1.3rem;
}

&__title {
font-size: 1.1rem;
font-weight: 600;
font-size: 1.125rem;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
image

After
image

font-weight: 600;
font-size: 0.85rem;
font-weight: 500;
font-size: 0.875rem;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before
image

After
image

@NotMyFault NotMyFault added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jun 15, 2024
@timja timja requested a review from a team June 16, 2024 18:46
@timja timja added the web-ui The PR includes WebUI changes which may need special expertise label Jun 19, 2024
@timja
Copy link
Member

timja commented Jun 20, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 20, 2024
@MarkEWaite MarkEWaite merged commit b00c2ad into jenkinsci:master Jun 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants