-
-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align font weights and font sizes #9393
Align font weights and font sizes #9393
Conversation
@@ -197,7 +197,7 @@ $semantics: ( | |||
--link-text-decoration: none; | |||
--link-text-decoration--hover: underline; | |||
--link-text-decoration--active: underline; | |||
--link-font-weight: 500; | |||
--link-font-weight: 450; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -39,7 +39,7 @@ $semantics: ( | |||
--font-size-base: 1rem; // 16px | |||
--font-size-sm: 0.875rem; // 14px | |||
--font-size-xs: 0.75rem; // 12px | |||
--font-size-monospace: 0.95em; | |||
--font-size-monospace: 1em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -155,7 +155,7 @@ pre { | |||
background-color: var(--pre-background); | |||
color: var(--pre-color); | |||
font-family: var(--font-family-mono); | |||
font-weight: 500; | |||
font-weight: 400; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -19,8 +19,8 @@ $jenkins-dialog-padding: 1.3rem; | |||
} | |||
|
|||
&__title { | |||
font-size: 1.1rem; | |||
font-weight: 600; | |||
font-size: 1.125rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
font-weight: 600; | ||
font-size: 0.85rem; | ||
font-weight: 500; | ||
font-size: 0.875rem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
Another small one to align font weights and font sizes, similar to #9367 #9366 #9365.
This MR largely decreases the weight of fonts across Jenkins, ideally increasing legibility and making Jenkins appear more consistent. Font sizes are also adjusted, aligning with whole pixels.
I'll annotate the MR with before/after screenshots.
Testing done
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@jenkinsci/sig-ux
Before the changes are marked as
ready-for-merge
:Maintainer checklist