Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine form controls appearance #9365

Merged
merged 6 commits into from
Jun 11, 2024

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jun 8, 2024

Small one to refine the appearance of form controls.

  • Colours tweaked to align closer to the https://jenkins-redesign.vercel.app/settings concept
  • Padding increased a touch to make controls more clickable, padding between controls decreased a touch to account for that
  • Border radius increased to align with buttons/cards/tables
image image

Refined input

image image

Focus states are now more vibrant, inline with the accent color/dark theme

image image
image image

Testing done

  • Form controls appear as expected

Proposed changelog entries

  • Refine form controls appearance.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

@timja timja added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Jun 8, 2024
@timja timja requested a review from a team June 8, 2024 20:50
@timja
Copy link
Member

timja commented Jun 10, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 10, 2024
@janfaracik
Copy link
Contributor Author

Pushed a small fix to CodeMirror's gutter, padding was off previously:

Before
image

After
image

@Kevin-CB Kevin-CB added the security-approved @jenkinsci/core-security-review reviewed this PR for security issues label Jun 11, 2024
@timja timja merged commit e7f3e23 into jenkinsci:master Jun 11, 2024
17 checks passed
@timja timja deleted the update-input-appearance branch June 11, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted security-approved @jenkinsci/core-security-review reviewed this PR for security issues web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants