[JENKINS-73156] handle svg cleanup of symbols via an xml document #9266
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some attributes and elements where removed via regular expressions that removed more than what is necessary. Additionally
stroke:#000
was replaced with currentColor because there are some icons that still use that.This had side-effects when symbols are used that are not just black/white, e.g. using svgs from jenkins artwork via customizable-header plugin. There are constructs like using class attributes and a style definition referring to the classes. At other places there where color definitions with
stroke:#000abc
which were incorrectly modified.svg cleanup is now implemented with DOM manipulation which is more robust.
5 icons that still used
stroke:#000
are converted to usestroke:currentColor
opened jenkinsci/ionicons-api-plugin#64 as followup to fix some occurrences of
stroke:#000
See JENKINS-73156.
Testing done
Manual testing, that the changed icons still work properly with dark theme.
Used some of the SVGs from https://www.jenkins.io/artwork/ and provided them as symbol in customizable-header plugin and verified they are properly shown
Proposed changelog entries
Proposed upgrade guidelines
update ionicons-api plugin to at least version 74.v93d5eb_813d5f
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist