Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some stroke:#000 occurrences #64

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

mawinter69
Copy link
Contributor

there are 3 files that still had stroke:#000 instead of stroke:currentColor

Testing done

Submitter checklist

there are 3 files that still had stroke:#000 instead of
stroke:currentColor
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW the ionic team have suggested we fix this in l:icon itself as thats how they do it via CSS attributes so they don't have to do what we're doing

@timja timja added the bug Something isn't working label May 12, 2024
@timja timja merged commit 93d5eb8 into jenkinsci:main May 12, 2024
14 checks passed
@mawinter69
Copy link
Contributor Author

FWIW the ionic team have suggested we fix this in l:icon itself as thats how they do it via CSS attributes so they don't have to do what we're doing

Not sure what you exactly mean, but if a symbol is more than just some lines in a single color it might have side-effects when applying styles unconditionally.

@timja
Copy link
Member

timja commented May 12, 2024

see ionic-team/ionicons#1129 (comment).

I wonder if there'd be a way to add it for just ionicons.

@mawinter69
Copy link
Contributor Author

afaik all icons in here have class="ionicon" (to be verified)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants