-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Swedish translation #9069
Conversation
…crediting translators of other languages
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
I have no idea on how to solve the build errors, so any help would be appreciated. |
I think it is complaining about the HTML files.
You can build it on your machine and check that you are seeing the same error. You can fix it with |
My local repo is currently broken, so I manually formatted the affected HTML files. However, I still get the same lint error. |
The correct way to fix prettier issues is by running |
That fixed the lint errors. Thanks!
Edit: It seems like it was an external issue, |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for the pull request.
I resolved the conflict and merged the latest changes from the master branch so that a new CI build would evaluate the pull request again.
I've run the Jenkins controller with locale set to "sv_SE" using the Jenkins locale plugin and was able to see the Swedish translations from my Google Chrome browser. I checked a few of the translations with Google translate and confirmed that Google translate agrees with the translated strings.
I don't speak Swedish, but I believe that @rsandell does. I've approved this pull request based on my testing and my use of google translate to confirm the few strings I checked agreed with Google translate.
Please take a moment and address the merge conflicts of your pull request. Thanks! |
@MarkEWaite Thanks for merging again. Is there anything I should do once the build is finished? |
No, I think that the preferred next step is a review by another Swedish speaker. If that doesn't happen within a week, I will ask for a review by someone who is not a Swedish speaker so that it can be merged. |
Thanks! /label ready-for-merge This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback. |
Congratulations on getting your very first Jenkins core pull request merged 🎉🥳 |
In this PR, I added new and updated existing properties/HTML files. There are some more HTML files to be translated, which I will take care of in a future PR.
No JIRA ticket. Since the majority of the most recent translation PRs lacked one, I figured this wasn't needed.
Testing done
Testing was done by browsing the various menus and settings to get proper context.
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@mention
Before the changes are marked as
ready-for-merge
:Maintainer checklist