Class loading deadlock between PermalinkProjectAction.Permalink
& PeepholePermalink
#8736
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A functional test in CloudBees CI was observed to hang occasionally. Inspecting the thread dump revealed an apparent class loading deadlock. It is unknown whether this would affect production scenarios.
Fundamentally the problem is the use of
static final
fields for non-constant expressions. It would be incompatible to just delete these fields, unfortunately; plugins using them include for examplebuild-symlink
build-alias-setter
copyartifact
run-selector
infradna-backup
(CloudBees CI)As noted here it is not always clear how to solve these problems compatibly.
Testing done
Test usually deadlocks. Thread dump after 7dee8b2
Proposed changelog entries
PermalinkProjectAction.Permalink
.Before the changes are marked as
ready-for-merge
:Maintainer checklist