Clearer reproducer

jenkinsci · Dec 1, 2023 · 7dee8b2 · 7dee8b2
1 parent d6fa103
commit 7dee8b2
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/core/src/main/java/jenkins/model/PeepholePermalink.java b/core/src/main/java/jenkins/model/PeepholePermalink.java
@@ -135,7 +135,7 @@ protected File getPermalinkFile(Job<?, ?> job) {
         return b;
     }
 
-    static @NonNull Map<String, Integer> cacheFor(@NonNull File buildDir) {
+    private static @NonNull Map<String, Integer> cacheFor(@NonNull File buildDir) {
         synchronized (caches) {
             Map<String, Integer> cache = caches.get(buildDir);
             if (cache == null) {

diff --git a/core/src/test/java/jenkins/model/PeepholePermalinkTest.java b/core/src/test/java/jenkins/model/PeepholePermalinkTest.java
@@ -28,7 +28,7 @@
 import static org.hamcrest.Matchers.is;
 
 import hudson.model.PermalinkProjectAction;
-import java.io.File;
+import hudson.model.Run;
 import org.junit.Test;
 
 public final class PeepholePermalinkTest {
@@ -39,7 +39,22 @@ public void classLoadingDeadlock() throws Exception {
             assertThat("successfully loaded LAST_STABLE_BUILD", PermalinkProjectAction.Permalink.LAST_STABLE_BUILD.getId(), is("lastStableBuild"));
         });
         t.start();
-        PeepholePermalink.cacheFor(new File("."));
+        new PeepholePermalink() {
+            @Override
+            public boolean apply(Run<?, ?> run) {
+                throw new UnsupportedOperationException();
+            }
+
+            @Override
+            public String getDisplayName() {
+                throw new UnsupportedOperationException();
+            }
+
+            @Override
+            public String getId() {
+                throw new UnsupportedOperationException();
+            }
+        };
         t.join();
     }