-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
French translations for plugin manager #8685
French translations for plugin manager #8685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -20,7 +20,7 @@ | |||
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | |||
# THE SOFTWARE. | |||
|
|||
Restarting \Jenkins=Redémarrage de Jenkins | |||
Restarting\ Jenkins=Redémarrage de Jenkins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! LGTM.
Please note that this repository also need validation from legit maintainers (which we are not, except for @olamy maybe) and follow the usual Jenkins Core PRs review process.
Failed after more than 1 hour of build (total) on the JDK21 build stage because of |
That's been an infrequent failure mode for the Java 21 build environments. I've been using retry as the temporary solution. I think we may need to open an infra ticket to help isolate the problem and resolve it. |
@NotMyFault All tests passed ^^. So I think it can be marked as "ready for merge" like #8684 ^^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/label ready-for-merge
This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!
All is in the title ^^.
This changes can be skipped for the changelog ^^.
Desired reviewers
@dduportal or @smerle33 or @lemeurherve or @gounthar or @olamy