Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French translations for plugin manager #8685

Merged

Conversation

Mysterious-Dev
Copy link
Contributor

All is in the title ^^.

This changes can be skipped for the changelog ^^.

Desired reviewers

@dduportal or @smerle33 or @lemeurherve or @gounthar or @olamy

@Mysterious-Dev Mysterious-Dev changed the title Complete some french translations for plugins Complete some French translations for plugins Nov 9, 2023
Copy link
Member

@lemeurherve lemeurherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -20,7 +20,7 @@
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
# THE SOFTWARE.

Restarting \Jenkins=Redémarrage de Jenkins
Restarting\ Jenkins=Redémarrage de Jenkins
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👏

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Please note that this repository also need validation from legit maintainers (which we are not, except for @olamy maybe) and follow the usual Jenkins Core PRs review process.

@gounthar
Copy link

gounthar commented Nov 9, 2023

Failed after more than 1 hour of build (total) on the JDK21 build stage because of Caused by: java.lang.OutOfMemoryError: Java heap space.

@MarkEWaite
Copy link
Contributor

Failed after more than 1 hour of build (total) on the JDK21 build stage because of Caused by: java.lang.OutOfMemoryError: Java heap space.

That's been an infrequent failure mode for the Java 21 build environments. I've been using retry as the temporary solution. I think we may need to open an infra ticket to help isolate the problem and resolve it.

@daniel-beck daniel-beck changed the title Complete some French translations for plugins French translations for plugin manager Nov 9, 2023
@Mysterious-Dev
Copy link
Contributor Author

Mysterious-Dev commented Nov 11, 2023

@NotMyFault All tests passed ^^. So I think it can be marked as "ready for merge" like #8684 ^^

@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Nov 11, 2023
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 11, 2023
@NotMyFault NotMyFault merged commit 3cb552d into jenkinsci:master Nov 12, 2023
17 checks passed
@Mysterious-Dev Mysterious-Dev deleted the plugins-french-translation branch November 13, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants