Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update French translation for Save button and add one for Apply #8684

Merged

Conversation

Mysterious-Dev
Copy link
Contributor

All is in the title ^^.

This changes can be skipped for the changelog ^^.

Desired reviewers

@dduportal or @smerle33 or @lemeurherve or @gounthar or @olamy

Copy link

@gounthar gounthar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks! 👍

Copy link
Contributor

@dduportal dduportal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Please note that this repository also need validation from legit maintainers (which we are not, except for @olamy maybe) and follow the usual Jenkins Core PRs review process.

@NotMyFault NotMyFault added the skip-changelog Should not be shown in the changelog label Nov 10, 2023
Copy link
Member

@NotMyFault NotMyFault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 10, 2023
@NotMyFault NotMyFault merged commit 790f773 into jenkinsci:master Nov 11, 2023
17 checks passed
@Mysterious-Dev Mysterious-Dev deleted the job-buttons-french-translation branch November 11, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants