Diagnostics for QuietDownCommandTest.quietDownShouldSuccessWithBlockPlusNonExpiredTimeoutAndRunningExecutor

[jglick]

Alternative diagnostics building on #8513; see jenkinsci/jenkins-test-harness#657 (comment) with @Vlatombe & @basil

Testing done

Test passes locally and shows

…
   9.481 [aProject #1] Finished: SUCCESS
   9.772 [id=20]	INFO	hudson.lifecycle.Lifecycle#onStatusUpdate: Stopping Jenkins
   9.828 [id=20]	FINEST	hudson.XmlFile#write: Writing …/queue.xml
java.lang.Throwable
	at hudson.XmlFile.write(XmlFile.java:205)
	at hudson.model.Queue.save(Queue.java:472)
	at jenkins.model.Jenkins._cleanUpPersistQueue(Jenkins.java:3921)
	at jenkins.model.Jenkins.cleanUp(Jenkins.java:3676)
	at org.jvnet.hudson.test.JenkinsRule._stopJenkins(JenkinsRule.java:566)
	at org.jvnet.hudson.test.JenkinsRule.after(JenkinsRule.java:514)
	at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:625)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:299)
	at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:293)
	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
	at java.base/java.lang.Thread.run(Thread.java:829)
WARN: The method class org.apache.commons.logging.impl.SLF4JLogFactory#release() was invoked.
WARN: Please see http://www.slf4j.org/codes.html#release for an explanation.
   9.842 [id=20]	INFO	hudson.lifecycle.Lifecycle#onStatusUpdate: Jenkins stopped
   9.889 [id=20]	INFO	o.j.h.t.TemporaryDirectoryAllocator#dispose: deleting …

as expected. Unknown if the culprit would in fact appear during a flake.

Proposed changelog entries

• N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[jglick]

Among other 🤨 in this test, this variable was unused.

[Vlatombe]

Thought of this though I wanted to have a generic option because this is typically the kind of failure appearing on Windows for reasons that can be unrelated to the test itself.

[jglick]

https://github.com/jenkinsci/jenkins/pull/8511/checks?check_run_id=17000216956 happened to be on Windows, perhaps just because Windows CI tends to be slower and more likely to expose race conditions, but I strongly suspect the flake in this case is the fault of the test.

[NotMyFault]

/label ready-for-merge

---

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!

[jglick]

https://github.com/jenkinsci/jenkins/pull/8640/checks?check_run_id=18102119192 👀