-
-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-71971][JEP-237] FIPS-140 compliant version of HudsonPrivateSecurityRealm #8393
[JENKINS-71971][JEP-237] FIPS-140 compliant version of HudsonPrivateSecurityRealm #8393
Conversation
Please take a moment and address the merge conflicts of your pull request. Thanks! |
core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java
Outdated
Show resolved
Hide resolved
core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java
Outdated
Show resolved
Hide resolved
core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java
Outdated
Show resolved
Hide resolved
core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java
Outdated
Show resolved
Hide resolved
core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java
Outdated
Show resolved
Hide resolved
core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java
Outdated
Show resolved
Hide resolved
test/src/test/java/hudson/security/HudsonPrivateSecurityRealmTest.java
Outdated
Show resolved
Hide resolved
test/src/test/java/hudson/security/HudsonPrivateSecurityRealmTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java
Outdated
Show resolved
Hide resolved
core/src/main/java/hudson/security/HudsonPrivateSecurityRealm.java
Outdated
Show resolved
Hide resolved
adding |
core/src/test/java/hudson/security/HudsonPrivateSecurityRealmTest.java
Outdated
Show resolved
Hide resolved
core/src/test/java/hudson/security/HudsonPrivateSecurityRealmTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no major problems with this PR.
Spotless failed the build. IMO Spotless means applying PR suggestions has a very small chance of being successful, so should just not be done. |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
test/src/test/java/hudson/security/HudsonPrivateSecurityRealmTest.java
Outdated
Show resolved
Hide resolved
test/src/test/java/hudson/security/HudsonPrivateSecurityRealmTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Daniel Beck <[email protected]>
failure on windows appears to be the known flake that @jglick and @Vlatombe are tackling in #8534 but is too old to contain the diagnostics from jenkinsci/jenkins-test-harness#657 |
Congratulations on getting your very first Jenkins core pull request merged 🎉🥳 |
Congratulations on the merged pull request @divyasivasamy. Much appreciated! In future pull requests, it would be best if you retained the formatting from the pull request template so that the automatic changelog generation process works as expected. I've inserted the headings into the pull request description and will confirm that the automatic changelog generation accepts the pull request, but it would be nice in future pull requests if automatic changelog maintenance could do the work instead of a person needing to do the work. |
JENKINS-71971 Allow the use of
HudsonPrivateSecurityRealm
with a FIPS compliant password algorithm.Prior to this change the internal security realm used bcrypt (which uses the blowfish algorithm) to hash passwords. Blowfish is not a FIPS compliant algorithm and as this was used in the initial install it meant a clean install setup via the wizard could never be FIPS-140 compliant.
This addresses that by Implementing an alternative (enabled by a
SystemProperty
that usesPBKDF2withHmacSHA512
.see also JEP-237
Testing done
To validate the FIPS Mode and create hash of the user password and store it.
to validate a given password during the authentication process against stored hash of the password
Proposed changelog entries
Proposed upgrade guidelines
N/A