Move Node monitoring option to app bar

[janfaracik]

PR to move the 'Node monitoring' option to the Nodes' app bar from the side panel. Also slight tweaks to the page to remove the sidebar and adds a short description to explain what the pages does.

Before

After

Before

After

Testing done

• Node monitoring works as before

Proposed changelog entries

• Move Node monitoring option to app bar.

Proposed upgrade guidelines

N/A

Submitter checklist

Beta Give feedback

1. The Jira issue, if it exists, is well-described.
2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
3. There is automated testing or an explanation as to why this change has no tests.
4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
8. For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[daniel-beck]

What underlying principle motivates this change? It does not seem to be justified by https://weekly.ci.jenkins.io/design-library/AppBar/

[janfaracik]

What underlying principle motivates this change? It does not seem to be justified by https://weekly.ci.jenkins.io/design-library/AppBar/

It'd align more so with https://weekly.ci.jenkins.io/design-library/Layouts/ 'Don't include actions or external pages in your sidebar, these belong in the top app bar'. It'd be consistent with the 'Log Recorders' interface.

[Wadeck]

Seems to be fine security wise

[timja]

Test failure needs looking at @janfaracik

[timja]

/label ready-for-merge

---

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[daniel-beck]

'Don't include actions or external pages in your sidebar, these belong in the top app bar'. It'd be consistent with the 'Log Recorders' interface.

This rule basically invalidates every RootAction.

[basil]

This change broke some core tests due to a markup change, so how do we know that it won't break plugin tests if we haven't run PCT?

[NotMyFault]

This change broke some core tests due to a markup change, so how do we know that it won't break plugin tests if we haven't run PCT?

=> jenkinsci/bom#2432

[basil]

Great!

[NotMyFault]

'
/label ready-for-merge

---

This PR is now ready for merge. We will merge it after ~24 hours if there is no negative feedback.
Please see the merge process documentation for more information about the merge process.
Thanks!