New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sidepanel/app bar rule needs changes #272

Open

daniel-beck opened this issue Aug 22, 2023 · 1 comment

Member

daniel-beck commented Aug 22, 2023

Per @janfaracik

What underlying principle motivates this change? It does not seem to be justified by https://weekly.ci.jenkins.io/design-library/AppBar/

It'd align more so with https://weekly.ci.jenkins.io/design-library/Layouts/ 'Don't include actions or external pages in your sidebar, these belong in the top app bar'. It'd be consistent with the 'Log Recorders' interface.

AFAICT, jenkinsci/jenkins#8381 (comment),

This rule basically invalidates every RootAction.

Given how common RootActions are, and the widespread impact of declaring that use of the sidepanel invalid, the rule should be overhauled.

The text was updated successfully, but these errors were encountered:

Member Author

daniel-beck commented Sep 9, 2023

jenkinsci/jenkins#6824 (comment) seems related. It'd probably introduce a third entry to the app bar.

The app bar is neither plugin-extensible, not does it look like it can reasonably hold more than 2, perhaps 3 entries. How is this supposed to work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment