Display JUnit test results as they appear #6091
Conversation
| } | ||
| } | ||
|
|
||
| // Once we've built, archive the artifacts and the test results. | ||
| stage("${buildType} Publishing") { | ||
| if (runTests) { | ||
| junit healthScaleFactor: 20.0, testResults: '*/target/surefire-reports/*.xml,war/junit.xml' |
There was a problem hiding this comment.
bit concerned that this will break checks api integration which is really nice:
jenkinsci/junit-plugin#320
There was a problem hiding this comment.
So what is the next step Tim? Close this PR?
There was a problem hiding this comment.
I'll take a look at the junit plugin in between form modernisation work and see how hard it would be to just properly integrate it or patch real time junit
There was a problem hiding this comment.
I think this PR would likely integrate it already: jenkinsci/junit-realtime-test-reporter-plugin#12
There was a problem hiding this comment.
I’m doing some testing on it and should have a release out by tomorrow so if we can just hold off till then that would be great (just want to make sure it’s viable)
Co-authored-by: Jesse Glick <[email protected]>
|
re-triggered good to go if it works |
|
Has the feedback from this review and this review been addressed? If so, is there a reason this PR has not yet been approved? |
just hadn't had a chance to check it, 're-triggered good to go if it works' ... |
Extracting a useful piece of #4447 into its own PR.
Proposed changelog entries
N/A
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entriessection only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare correctupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidateto be considered (see query).