update min Java version, Maven dependencies and plugins #92

don-vip · 2017-11-11T15:12:51Z

No description provided.

Signed-off-by: Vincent Privat <[email protected]>

don-vip · 2017-11-11T15:47:11Z

Travis build if failing for OpenJDK7 only. Do you want to keep it, or could we drop it and keep only support of OpenJDK8+?

…errors

centic9 · 2017-11-28T11:53:03Z

src/main/java/hudson/plugins/jacoco/JacocoBuildAction.java

@@ -383,6 +384,6 @@ public void onLoad(Run<?, ?> run) {

 	@Override
 	public Collection<? extends Action> getProjectActions() {
-		return jacocoProjectActions;
+		return jacocoProjectAction != null ? Arrays.asList(jacocoProjectAction) : Collections.emptyList();


I would use Collections.singletonList() here instead of Arrays.asList()

centic9 · 2017-11-28T11:53:31Z

src/main/java/hudson/plugins/jacoco/ExecutionFileLoader.java

@@ -33,10 +34,10 @@
 		private String[] includes;
 		private String[] excludes;

-		private ExecutionDataStore executionDataStore;
-		private SessionInfoStore sessionInfoStore;
+		private transient ExecutionDataStore executionDataStore;


Can you add a comment why "transient" is necessary/useful here?

Sure. It's because of the switch to org.jenkins-ci.plugins 3.0, which defines a FindBugs analysis.

centic9 · 2017-11-28T11:54:09Z

pom.xml

@@ -97,7 +97,10 @@ THE SOFTWARE.
      <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
      <project.build.outputEncoding>UTF-8</project.build.outputEncoding>
      <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
+      <ant.version>1.9.2</ant.version>


Why do we need a dependency on Ant now?

It was to fix this error, but it's probably not the best way:

[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ jacoco --- [INFO] Ignoring requireUpperBoundDeps in org.kohsuke:access-modifier-annotation [WARNING] Rule 6: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message: Failed while enforcing RequireUpperBoundDeps. The error(s) are [ Require upper bound dependencies error for org.apache.ant:ant:1.8.4 paths to dependency are: +-org.jenkins-ci.plugins:jacoco:2.3-SNAPSHOT +-org.jenkins-ci.main:jenkins-core:2.54 +-org.apache.ant:ant:1.8.4 and +-org.jenkins-ci.plugins:jacoco:2.3-SNAPSHOT +-org.jenkins-ci.plugins:dashboard-view:2.9.11 +-org.jenkins-ci.main:maven-plugin:2.13 +-org.jenkins-ci.main.maven:maven-agent:1.7 +-org.apache.ant:ant:1.8.4 and +-org.jenkins-ci.plugins:jacoco:2.3-SNAPSHOT +-org.jenkins-ci.plugins:dashboard-view:2.9.11 +-org.jenkins-ci.main:maven-plugin:2.13 +-org.jenkins-ci.lib:lib-jenkins-maven-embedder:3.11 +-org.apache.ant:ant:1.9.2

centic9 · 2017-11-28T11:54:35Z

pom.xml

+	  </dependency>
+      <dependency>
+	    <groupId>xerces</groupId>
+	    <artifactId>xercesImpl</artifactId>


Xerces dependency should not be needed since Java 7, why is it necessary here?

To fix this error but I should find another way:

[INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (display-info) @ jacoco --- [INFO] Ignoring requireUpperBoundDeps in org.kohsuke:access-modifier-annotation [WARNING] Rule 6: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message: Failed while enforcing RequireUpperBoundDeps. The error(s) are [ Require upper bound dependencies error for xerces:xercesImpl:2.9.1 paths to dependency are: +-org.jenkins-ci.plugins:jacoco:2.3-SNAPSHOT +-org.apache.maven.reporting:maven-reporting-impl:2.3 +-org.apache.maven.doxia:doxia-core:1.2 +-xerces:xercesImpl:2.9.1 and +-org.jenkins-ci.plugins:jacoco:2.3-SNAPSHOT +-org.jenkins-ci.main:jenkins-test-harness:2.32 +-org.jenkins-ci.main:jenkins-test-harness-htmlunit:2.18-1 +-xerces:xercesImpl:2.11.0 and +-org.jenkins-ci.plugins:jacoco:2.3-SNAPSHOT +-org.jenkins-ci.main:jenkins-test-harness:2.32 +-org.jenkins-ci.main:jenkins-test-harness-htmlunit:2.18-1 +-net.sourceforge.nekohtml:nekohtml:1.9.22 +-xerces:xercesImpl:2.11.0

centic9 · 2017-11-28T11:55:08Z

pom.xml

+	    <version>${ant.version}</version>
+	  </dependency>
+      <dependency>
+	    <groupId>commons-io</groupId>


I don't see any usages of commons-io in the changed code, why is the dependency necessary now?

Same reason than ant, but not needed anymore after a new update

centic9 · 2017-11-28T11:55:55Z

pom.xml

@@ -195,30 +215,76 @@ THE SOFTWARE.
            <version>3.5</version>
            <scope>test</scope>
        </dependency>
+        <dependency>
+            <groupId>org.apache.maven.reporting</groupId>


Why do we need all these Maven dependencies now? Where do we actually use functionality from them?

Because of the switch to org.jenkins-ci.plugins 3.0, which defines a very strict maven enforcer configuration. If not met, the build fails. The enforcer rule causing all of this is "Require Upper Bound Dependencies".

centic9 · 2017-11-28T11:57:55Z

src/main/java/hudson/plugins/jacoco/portlet/JacocoLoadData.java

@@ -137,7 +131,7 @@ private static void summarize(Map<String, JacocoCoverageResultSummary> summaries

    JacocoCoverageResultSummary jacocoCoverageResult = getResult(run);

-	String date = DATE_FORMAT.format(runDate.getTime());
+	String date = new SimpleDateFormat("yyyy-MM-dd").format(runDate.getTime());


Unfortunately you are mixing many different changes here, not only Java 7->8, these seem to be intended to improve concurrent behavior somehow. This makes review a bit harder, would in general be better to send separate PRs for these unrelated changes.

This is not unrelated. Yet again caused by the switch to org.jenkins-ci.plugins 3.0 and the underlying FindBugs analysis. If not fixed, the build fails.

don-vip · 2017-12-05T22:06:04Z

This new enforcer rule is annoying. For example, I am trying to update to parent pom 3.2, and this is what I get:

[WARNING] Rule 6: org.apache.maven.plugins.enforcer.RequireUpperBoundDeps failed with message:
Failed while enforcing RequireUpperBoundDeps. The error(s) are [
Require upper bound dependencies error for org.ow2.asm:asm:6.0 paths to dependency are:
+-org.jenkins-ci.plugins:jacoco:2.3-SNAPSHOT
  +-org.ow2.asm:asm:6.0
and
+-org.jenkins-ci.plugins:jacoco:2.3-SNAPSHOT
  +-org.ow2.asm:asm-commons:6.0
    +-org.ow2.asm:asm-tree:6.0
      +-org.ow2.asm:asm:6.0
and
+-org.jenkins-ci.plugins:jacoco:2.3-SNAPSHOT
  +-org.apache.maven.plugins:maven-plugin-plugin:3.5
    +-org.apache.maven.plugin-tools:maven-plugin-tools-generators:3.5
      +-org.ow2.asm:asm:6.0_ALPHA
and
+-org.jenkins-ci.plugins:jacoco:2.3-SNAPSHOT
  +-org.apache.maven.plugins:maven-plugin-plugin:3.5
    +-org.apache.maven.plugin-tools:maven-plugin-tools-annotations:3.5
      +-org.ow2.asm:asm:6.0_ALPHA
and
+-org.jenkins-ci.plugins:jacoco:2.3-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:2.54
    +-com.github.jnr:jnr-posix:3.0.1
      +-com.github.jnr:jnr-ffi:1.0.7
        +-org.ow2.asm:asm:4.0
,
Require upper bound dependencies error for org.ow2.asm:asm-commons:6.0 paths to dependency are:
+-org.jenkins-ci.plugins:jacoco:2.3-SNAPSHOT
  +-org.ow2.asm:asm-commons:6.0
and
+-org.jenkins-ci.plugins:jacoco:2.3-SNAPSHOT
  +-org.apache.maven.plugins:maven-plugin-plugin:3.5
    +-org.apache.maven.plugin-tools:maven-plugin-tools-generators:3.5
      +-org.ow2.asm:asm-commons:6.0_ALPHA
and
+-org.jenkins-ci.plugins:jacoco:2.3-SNAPSHOT
  +-org.jenkins-ci.main:jenkins-core:2.54
    +-com.github.jnr:jnr-posix:3.0.1
      +-com.github.jnr:jnr-ffi:1.0.7
        +-org.ow2.asm:asm-commons:4.0
]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 11.768 s
[INFO] Finished at: 2017-12-05T23:04:09+01:00
[INFO] Final Memory: 39M/130M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M1:enforce (display-info) on project jacoco: Some Enforcer rules have failed. Look above for specific messages explaining why the rule failed. -> [Help 1]

kscaldef · 2018-01-09T19:53:28Z

What are the prospects for moving this along? I was making a pass at updating to the newly released JaCoCo 0.8 version it appears that requiring JDK 1.7 compatibility is holding it back

don-vip · 2018-01-09T21:40:39Z

I'm still waiting for apache/maven-plugin-tools#9 to be merged, I didn't think it would take this long.

don-vip · 2018-01-10T00:45:54Z

OK it appears the other PR in maven-plugin-tools is not needed anymore, no need to wait for it.
@centic9 : can you please check if everything's OK now?

centic9 · 2018-01-10T18:23:21Z

Looks good now, I expect we will release a major version due to the changes in dependencies.

kscaldef · 2018-02-14T15:36:44Z

@centic9 any idea when that release will happen?

centic9 · 2018-02-18T18:01:11Z

I tried to release, but as usual the release-steps fail at some point with some permission denied. It seems I am not able to get this solved in a way that works longer than for one release, grrr.... anybody else who knows what to do?

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-deploy-plugin:2.8.2:deploy (default-deploy) on project jacoco: Failed to deploy artifacts: Could not transfer artifact org.jenkins-ci.plugins:jacoco:hpi:3.0 from/to maven.jenkins-ci.org (https://repo.jenkins-ci.org/releases): Access denied to: https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/jacoco/3.0/jacoco-3.0.hpi, ReasonPhrase: . -> [Help 1]

I re-created the settings.xml and checked other things, but to no avail ...

don-vip added 3 commits November 11, 2017 16:10

update Maven dependencies and plugins

369619b

Signed-off-by: Vincent Privat <[email protected]>

fix Travis configuration

edce266

Signed-off-by: Vincent Privat <[email protected]>

do not test jdk9 yet, revert maven-hpi-plugin update to keep jdk7

f76a91b

Signed-off-by: Vincent Privat <[email protected]>

drop Java 7 support, update parent-pom to 3.0, fix enforcer/findbugs …

3b6344e

…errors

don-vip changed the title ~~update Maven dependencies and plugins~~ update min Java version, Maven dependencies and plugins Nov 24, 2017

centic9 reviewed Nov 28, 2017

View reviewed changes

don-vip mentioned this pull request Dec 6, 2017

upgrade to ASM 6.1.1 apache/maven-plugin-tools#9

Merged

don-vip added 3 commits January 10, 2018 01:28

update to jacoco 0.8.0 + others, and fix Maven dependencies

5ff0eb5

fix indentation in dependencyManagement block

75a613d

use Collections.singletonList() instead of Arrays.asList()

099f6db

centic9 merged commit d04b509 into jenkinsci:master Jan 10, 2018

don-vip deleted the updates branch January 10, 2018 20:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update min Java version, Maven dependencies and plugins #92

update min Java version, Maven dependencies and plugins #92

don-vip commented Nov 11, 2017 •

edited

Loading

don-vip commented Nov 11, 2017

centic9 Nov 28, 2017

don-vip Dec 5, 2017

don-vip Jan 10, 2018

centic9 Nov 28, 2017

don-vip Dec 5, 2017

centic9 Nov 28, 2017

don-vip Jan 9, 2018

centic9 Nov 28, 2017

don-vip Jan 9, 2018

centic9 Nov 28, 2017

don-vip Jan 9, 2018

centic9 Nov 28, 2017

don-vip Dec 5, 2017

centic9 Nov 28, 2017

don-vip Dec 5, 2017

don-vip commented Dec 5, 2017

kscaldef commented Jan 9, 2018

don-vip commented Jan 9, 2018

don-vip commented Jan 10, 2018

centic9 commented Jan 10, 2018

kscaldef commented Feb 14, 2018

centic9 commented Feb 18, 2018

update min Java version, Maven dependencies and plugins #92

update min Java version, Maven dependencies and plugins #92

Conversation

don-vip commented Nov 11, 2017 • edited Loading

don-vip commented Nov 11, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

don-vip commented Dec 5, 2017

kscaldef commented Jan 9, 2018

don-vip commented Jan 9, 2018

don-vip commented Jan 10, 2018

centic9 commented Jan 10, 2018

kscaldef commented Feb 14, 2018

centic9 commented Feb 18, 2018

don-vip commented Nov 11, 2017 •

edited

Loading