Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to ASM 6.1.1 #9

Merged
merged 1 commit into from
May 5, 2018
Merged

upgrade to ASM 6.1.1 #9

merged 1 commit into from
May 5, 2018

Conversation

don-vip
Copy link
Contributor

@don-vip don-vip commented Dec 6, 2017

The ALPHA dependency causes problems to projects using Enforcer rules, see jenkinsci/jacoco-plugin#92 (comment)

don-vip referenced this pull request Dec 7, 2017
Introduce jdk9 profile with ASM 6.0_ALPHA

git-svn-id: https://svn.apache.org/repos/asf/maven/plugin-tools/trunk@1757907 13f79535-47bb-0310-9956-ffa450edef68
@don-vip
Copy link
Contributor Author

don-vip commented Jan 9, 2018

@rfscholte is there a problem holding back to merge this PR?

@rfscholte
Copy link
Contributor

time...

@don-vip
Copy link
Contributor Author

don-vip commented Jan 9, 2018

ok :)

@don-vip don-vip changed the title upgrade to ASM 6.0 (final) upgrade to ASM 6.1 Mar 11, 2018
@don-vip don-vip changed the title upgrade to ASM 6.1 upgrade to ASM 6.1.1 Apr 2, 2018
@aldaris
Copy link
Contributor

aldaris commented May 3, 2018

With ASM 6.1.1 maven-plugin-plugin would also support JDK10.

@olamy
Copy link
Member

olamy commented May 3, 2018

any jira issue?

@aldaris
Copy link
Contributor

aldaris commented May 4, 2018

@khmarbaise
Copy link
Member

Hi, could you please squash your commits and make a commit message like:

[MPLUGIN-335] - Support JDK 10 for plugin generation
 o More description if needed

So I would appreciate to merge this into....

@don-vip
Copy link
Contributor Author

don-vip commented May 4, 2018

Done.

@olamy olamy merged commit 7dfedcb into apache:master May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants