-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add secondary ingress #63
Conversation
Signed-off-by: Gavin Mogan <[email protected]>
a6ed240
to
95c0373
Compare
Signed-off-by: Gavin Mogan <[email protected]>
Signed-off-by: Gavin Mogan <[email protected]>
tested via:
|
Signed-off-by: Gavin Mogan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a changelog entry https://github.com/jenkinsci/helm-charts/blob/main/charts/jenkins/CHANGELOG.md
charts/jenkins/Chart.yaml
Outdated
@@ -1,7 +1,7 @@ | |||
apiVersion: v1 | |||
name: jenkins | |||
home: https://jenkins.io/ | |||
version: 2.6.4 | |||
version: 2.6.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
version: 2.6.5 | |
version: 2.7.0 |
Signed-off-by: Gavin Mogan <[email protected]>
enabled: false | ||
# paths you want forwarded to the backend | ||
# ex /github-webhook | ||
paths: [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about putting the github webhook in here by default commented out?
I suspect that would be what it's used for the majority of the time
paths: [] | |
paths: [] | |
#paths: | |
# - /github-webhook |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does helm merge or overwrite arrays?
if its merge, that would mean there's no way to disable it
What about the straight up non github webhook? I think its /notifyCommit
What about prefixes? by making it need to be configured, its able to be prefixed, the default wouldn't be.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, it overwrites a list, so it would be doable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had it commented out to avoid those issues 👅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oooh i get what your saying, i can change it if desired when i'm on a computer again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is fine 🚢
Signed-off-by: Gavin Mogan <[email protected]>
What this PR does / why we need it
Which issue this PR fixes
Special notes for your reviewer
Checklist