Add secondary ingress

[halkeye]

What this PR does / why we need it

Which issue this PR fixes

• fixes Add secondary ingress to allow webhooks to be public #44 - Allow a secondary ingress for making webbooks public

Special notes for your reviewer

Checklist

• DCO signed
• Chart Version bumped
• CHANGELOG.md was updated

[halkeye]

tested via:

---
# Source: jenkins/templates/jenkins-master-secondary-ingress.yaml
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
  namespace: media
  labels:
    "app.kubernetes.io/name": 'jenkins'
    "helm.sh/chart": "jenkins-2.6.5"
    "app.kubernetes.io/managed-by": "Helm"
    "app.kubernetes.io/instance": "RELEASE-NAME"
    "app.kubernetes.io/component": "jenkins-master"
    labela: valuea
    labelb: valueb
  annotations:
    annoitationa: valuea
    annoitationb: valueb
  name: RELEASE-NAME-jenkins-secondary
spec:
  rules:
    - host: something
      http:
        paths:
          - path: "/github-webhook"
            backend:
              serviceName: RELEASE-NAME-jenkins
              servicePort: 8080
  tls:
    - hosts:
      - jenkins-external.example.com
      secretName: jenkins-external.example.com

 cat value2.yaml
master:
  ingress:
    enabled: false
    hostName: 'foo'
  secondaryingress:
    enabled: true
    # paths you want forwarded to the backend
    # ex /github-webhook
    paths:
      - /github-webhook
    # For Kubernetes v1.14+, use 'networking.k8s.io/v1beta1'
    apiVersion: "extensions/v1beta1"
    labels:
      labela: valuea
      labelb: valueb
    annotations:
      annoitationa: valuea
      annoitationb: valueb
    # kubernetes.io/ingress.class: nginx
    # kubernetes.io/tls-acme: "true"
    # configures the hostname e.g. jenkins-external.example.com
    hostName: something
    tls:
      - secretName: jenkins-external.example.com
        hosts:
          - jenkins-external.example.com

[timja]

please add a changelog entry https://github.com/jenkinsci/helm-charts/blob/main/charts/jenkins/CHANGELOG.md

[timja]

Suggested change

	version: 2.6.5
	version: 2.7.0

[timja]

what about putting the github webhook in here by default commented out?

I suspect that would be what it's used for the majority of the time

Suggested change

	paths: []
	paths: []
	#paths:
	# - /github-webhook

[halkeye]

does helm merge or overwrite arrays?
if its merge, that would mean there's no way to disable it

What about the straight up non github webhook? I think its /notifyCommit
What about prefixes? by making it need to be configured, its able to be prefixed, the default wouldn't be.

[halkeye]

ah, it overwrites a list, so it would be doable.

[timja]

I had it commented out to avoid those issues 👅

[halkeye]

oooh i get what your saying, i can change it if desired when i'm on a computer again

[timja]

is fine 🚢