Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secondary ingress to allow webhooks to be public #44

Closed
halkeye opened this issue Sep 9, 2020 · 4 comments · Fixed by #63
Closed

Add secondary ingress to allow webhooks to be public #44

halkeye opened this issue Sep 9, 2020 · 4 comments · Fixed by #63
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@halkeye
Copy link
Member

halkeye commented Sep 9, 2020

Is your feature request related to a problem? Please describe.
We have various jenkins installation that contain sensitive data, and thus hidden behind firewalls, but still would like github notifications

Describe the solution you'd like
Add a secondary ingress that just exposes the webhook urls (github-webhook/bitbucket-webhook/etc)

Describe alternatives you've considered
Could use a sidecar container that starts up smee, but thats an extra dependancyan

@halkeye halkeye added the enhancement New feature or request label Sep 9, 2020
@torstenwalter
Copy link
Member

That's a good idea. We are actually doing something like this in our setup.

Would you like to submit a PR for that?

@halkeye
Copy link
Member Author

halkeye commented Sep 9, 2020

If i get to it sure, but totally up for others to contribute too. I think its a decent newbie friendly issue (I'm practicing labeling before hacktober next month)

@torstenwalter
Copy link
Member

If i get to it sure, but totally up for others to contribute too. I think its a decent newbie friendly issue (I'm practicing labeling before hacktober next month)

Do you have a convention which label should be used for newbie friendly issues?

@halkeye
Copy link
Member Author

halkeye commented Sep 9, 2020

"good first issue" is usually the convention. the standard labels should be on new repos, so you should have it.

@torstenwalter torstenwalter added the good first issue Good for newcomers label Sep 9, 2020
@halkeye halkeye mentioned this issue Sep 18, 2020
3 tasks
@timja timja closed this as completed in #63 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants