Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not bundle eddsa library #465

Merged
merged 1 commit into from
May 30, 2024
Merged

Do not bundle eddsa library #465

merged 1 commit into from
May 30, 2024

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented May 17, 2024 •
edited
Loading

the same version comes from the trilead-api plugin that we depend on so it would not be used as it does not have the plugin-first classloader.

remove the exclusion from trilead and remove the bundling in this plugin

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jtnord
Do not bundle eddsa library
b606bd3 
the same version comes from the trilead-api plugin that we depend on so
it would not be used as it does not have the plugin-first classloader.

remove the exclusion from trilead and remove the bundling in this
plugin
@jtnord jtnord mentioned this pull request May 17, 2024
Merged
@jtnord jtnord requested a review from a team May 17, 2024 11:20
@rsandell rsandell added dependencies Pull requests that update a dependency file developer labels May 30, 2024
@jtnord jtnord merged commit 6969b7c into jenkinsci:develop May 30, 2024
14 checks passed
@jtnord jtnord deleted the do-not-bundle-eddsa branch May 30, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsandell rsandell rsandell approved these changes

@olamy olamy olamy approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtnord @olamy @rsandell