-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove "tasklist" in pull_request_template.md and replace with stock checkboxes #136
Conversation
the ```[tasklist] caused the tasklist to be rendered as code and not as a task list in the PRs that used this PR. e.g. use the preview on the existing file https://github.com/jenkinsci/.github/blob/ba0b88f732b4f48ed84c583524e2345427cd3f0c/.github/pull_request_template.md#testing-done
It doesn't though? i.e. check the description from this PR or e.g. jenkinsci/acceptance-test-harness#1563 |
AFAIK the current syntax is the expected one for GitHub to render this block as a task list instead of a simple list. The code block rendering is shown in the preview only, then rendered as a proper task list when submitted. |
THen GitHub is playing beta testing as I am constantly having to remove this from my PRs. e.g. see jenkinsci/google-compute-engine-plugin#465 |
That's expected, GitHub doesn't render a proper task list on preview, only when posted. |
I encountered intermittent issues these last days when submitting PRs with task list returning an error message block instead, but editing the body and copy/pasting from a new template resolved it each time. |
? it does it you remove the bits ``` ?
I also see regularly see that. Right so my PR is then just a regular list of checkboxes not a "tasklist" but Tasklists is on life support and will be replaced with something else in the future. given this is often broken recently and breaks preview does this extra actually bring any value? |
I don't modify nor remove the backticks when posting or editing.
Thanks for the link and info! EDIT:
I agree there is little to no value added with a task list compared to a normal list, they both are counted in listings. The only diff is that there is a "done" count in the task list instead of just the total count. VS |
the ```[tasklist] caused the tasklist to be rendered as code in preview, and has often been broken this passed week.
checkboxes work, so just replace the tasklist with them.
e.g. use the preview on the existing file https://github.com/jenkinsci/.github/blob/ba0b88f732b4f48ed84c583524e2345427cd3f0c/.github/pull_request_template.md#testing-done
Testing done
Submitter checklist