Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SCM information #924

Merged
merged 1 commit into from
Feb 14, 2023
Merged

Update SCM information #924

merged 1 commit into from
Feb 14, 2023

Conversation

jtnord
Copy link
Member

@jtnord jtnord commented Feb 14, 2023 •
edited
Loading

remove the no longer supported anonymous git access URL

do not app child names to SCM entries as this produces incorrect metadata that then fails with the PCT

fixes failure observed when testing jenkinsci/plugin-compat-tester#452

2023-02-14 12:57:13.263+0000 [id=1]     INFO    o.j.t.t.h.AbstractMultiParentHook#action: Executing hook for Amazon Web Services SDK :: EC2
2023-02-14 12:57:13.264+0000 [id=1]     INFO    o.j.t.t.h.AbstractMultiParentHook#action: Preparing for multi-module checkout
2023-02-14 12:57:13.264+0000 [id=1]     INFO    o.j.t.test.PluginCompatTester#cloneImpl: Checking out from git repository https://github.com/jenkinsci/aws-java-sdk-plugin.git/aws-java-sdk-ec2 at f82d85a6eefd551622141a11e762108aec3aed48
2023-02-14 12:57:14.070+0000 [id=1]     INFO    o.j.t.test.PluginCompatTester#cloneImpl: Checking out from git repository [email protected]:jenkinsci-cert/aws-java-sdk-plugin.git/aws-java-sdk-ec2 at f82d85a6eefd551622141a11e762108aec3aed48
2023-02-14 12:57:16.431+0000 [id=1]     INFO    o.j.t.test.PluginCompatTester#cloneImpl: Checking out from git repository https://github.com/jenkinsci-cert/aws-java-sdk-plugin.git/aws-java-sdk-ec2 at f82d85a6eefd551622141a11e762108aec3aed48
org.jenkins.tools.test.exception.PluginSourcesUnavailableException: git fetch origin failed with exit status 128: remote: Not Found
fatal: repository 'https://github.com/jenkinsci-cert/aws-java-sdk-plugin.git/aws-java-sdk-ec2/' not found
        at org.jenkins.tools.test.PluginCompatTester.cloneImpl(PluginCompatTester.java:559)
        at org.jenkins.tools.test.PluginCompatTester.cloneFromScm(PluginCompatTester.java:462)
        at org.jenkins.tools.test.hook.AbstractMultiParentHook.action(AbstractMultiParentHook.java:48)
        at org.jenkins.tools.test.model.hook.PluginCompatTesterHooks.runHooks(PluginCompatTesterHooks.java:125)
        at org.jenkins.tools.test.model.hook.PluginCompatTesterHooks.runBeforeCheckout(PluginCompatTesterHooks.java:96)
        at org.jenkins.tools.test.PluginCompatTester.testPluginAgainst(PluginCompatTester.java:266)
        at org.jenkins.tools.test.PluginCompatTester.testPlugins(PluginCompatTester.java:177)
        at org.jenkins.tools.test.PluginCompatTesterCli.call(PluginCompatTesterCli.java:202)
        at org.jenkins.tools.test.PluginCompatTesterCli.call(PluginCompatTesterCli.java:42)
        at picocli.CommandLine.executeUserObject(CommandLine.java:2041)
        at picocli.CommandLine.access$1500(CommandLine.java:148)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2461)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2453)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2415)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2273)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2417)
        at picocli.CommandLine.execute(CommandLine.java:2170)
        at org.jenkins.tools.test.PluginCompatTesterCli.main(PluginCompatTesterCli.java:207)
        Suppressed: org.jenkins.tools.test.exception.PluginSourcesUnavailableException: git fetch origin failed with exit status 128: fatal: remote error:
  jenkinsci-cert/aws-java-sdk-plugin.git/aws-java-sdk-ec2 is not a valid repository name
  Visit https://support.github.com/ for help
                ... 18 more
                Suppressed: org.jenkins.tools.test.exception.PluginSourcesUnavailableException: git fetch origin failed with exit status 128: remote: Not Found
fatal: repository 'https://github.com/jenkinsci/aws-java-sdk-plugin.git/aws-java-sdk-ec2/' not found
                        ... 18 more
  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@jtnord
Update SCM information
7c4e2ae 
remove the no longer supported anonymous git access URL

do not app child names to SCM entries as this produces incorrect
metadata that then fails with the PCT
jtnord
jtnord commented Feb 14, 2023
View reviewed changes
pom.xml
@@ -29,10 +29,10 @@
<email>[email protected]</email>
</developer>
</developers>
<scm>
<connection>scm:git:git://github.com/jenkinsci/aws-java-sdk-plugin.git</connection>
<scm child.scm.connection.inherit.append.path="false" child.scm.developerConnection.inherit.append.path="false" child.scm.url.inherit.append.path="false">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modules now retain exactly this configuration rather than appending ${project.artifactId}

pom.xml
<scm>
<connection>scm:git:git://github.com/jenkinsci/aws-java-sdk-plugin.git</connection>
<scm child.scm.connection.inherit.append.path="false" child.scm.developerConnection.inherit.append.path="false" child.scm.url.inherit.append.path="false">
<connection>scm:git:https://github.com/jenkinsci/aws-java-sdk-plugin.git</connection>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to https to fix
[WARNING] <connection>scm:git:git://github.com/jenkinsci/aws-java-sdk-plugin.git/aws-java-sdk-ec2</connection> is invalid because git:// URLs are deprecated. Replace it with <connection>scm:git:https://github.com/jenkinsci/aws-java-sdk-plugin.git/aws-java-sdk-ec2</connection>. In the future this warning will be changed to an error and will break the build.

@jtnord jtnord mentioned this pull request Feb 14, 2023
Merged
jglick
jglick approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vlatombe I think this needs a release.

pom.xml
<scm>
<connection>scm:git:git://github.com/jenkinsci/aws-java-sdk-plugin.git</connection>
<scm child.scm.connection.inherit.append.path="false" child.scm.developerConnection.inherit.append.path="false" child.scm.url.inherit.append.path="false">
<connection>scm:git:https://github.com/jenkinsci/aws-java-sdk-plugin.git</connection>
<developerConnection>scm:git:[email protected]:jenkinsci/aws-java-sdk-plugin.git</developerConnection>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to also use HTTPS here: jenkinsci/archetypes#267

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left this alone, most devs are setup to use SSH access and so this makes manual security releases less painful in the most part (you are probable not going to need that here) - but it makes things at least less controversial for a patch and the maintainers could choose to adopt this if they wanted at their conveinience.

@Vlatombe Vlatombe merged commit 070b05f into jenkinsci:master Feb 14, 2023
@jglick
Copy link
Member

jglick commented Feb 14, 2023

https://github.com/jenkinsci/aws-java-sdk-plugin/actions/runs/4175013240/jobs/7229353134 401 problem needs to be retried.

BTW I would recommend using the developer label for PRs like these—still triggers a release, but makes it clearer to users that there is no change to production behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vlatombe Vlatombe Vlatombe approved these changes

@jglick jglick jglick approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtnord @jglick @Vlatombe