Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for missing <scm> section #452

Closed
basil opened this issue Feb 8, 2023 · 0 comments · Fixed by #453
Closed

Remove support for missing <scm> section #452

basil opened this issue Feb 8, 2023 · 0 comments · Fixed by #453
Labels

Comments

@basil
Copy link
Member

basil commented Feb 8, 2023

It turned out that there were a handful (less than 5) of plugins that were missing an SCM section, resulting in #451. It would be ideal to fix those plugins and then to rip out support for plugins without an SCM section along with the second half of this if statement:

    public static String getScmTag(PomData pomData, String name, String version) {
        String scmTag;
        if (pomData.getScmTag() != null) {
            scmTag = pomData.getScmTag();
            LOGGER.log(Level.INFO, "Using SCM tag {0} from POM", scmTag);
        } else {
            scmTag = name + "-" + version;
            LOGGER.log(Level.INFO, "POM did not provide an SCM tag; inferring tag {0}", scmTag);
        }
        return scmTag;
    }

This cleanup would then cascade into the inlining of this function and the removal of the getParentProjectName() method, of which this is the only consumer.

The reason it would be ideal is that it is not very maintainable to have to maintain two code paths when the second is so rarely used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant