fix(versions): Delete and reclone version stream significantly less. #5981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmuir
reviewed
Oct 30, 2019
| @@ -869,6 +869,11 @@ func (g *GitCLI) FetchTags(dir string) error { | |||
| return g.gitCmd(dir, "fetch", "--tags") | |||
| } | |||
|
|
|||
| // FetchRemoteTags fetches all the tags from a remote repository | |||
| func (g *GitCLI) FetchRemoteTags(dir string, repo string) error { | |||
There was a problem hiding this comment.
Might be better to extend the command above, and check if repo is empty?
There was a problem hiding this comment.
Yeah, I think I'm gonna do a dive through git_cli at some point soon and clean up a bunch of stuff.
pmuir
reviewed
Oct 30, 2019
| if err != nil { | ||
| dir, err := deleteAndReClone(wrkDir, versionRepository, versionRef, gitter) | ||
| if err != nil { | ||
| return "", "", errors.WithStack(err) | ||
| } | ||
| return dir, versionRef, nil | ||
| } | ||
| // TODO: It might be good to do the same behavior for any branch - just the checkout approach works for | ||
| // tags and commit-ishs, but not branches. I'm not sure how we can tell if it's a branch vs a tag, though. |
There was a problem hiding this comment.
The only way I know how to do this is to use the FilterTags method to check if the tag exists or not
|
/lgtm |
By switching to an approach using our `Gitter` APIs rather than the `go-git` for handling an existing clone, we should drastically decrease the number of delete and reclones. fixes jenkins-x#5976 Signed-off-by: Andrew Bayer <[email protected]>
abayer
force-pushed
the
get-rid-of-branch-specific-fetch-logic-in-versionstream-gitrepo
branch
from
5b47fa9
to
2a57332
Compare
Signed-off-by: Andrew Bayer <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pmuir The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test all |
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter checklist
Description
By switching to an approach using our
GitterAPIs rather than thego-gitfor handling an existing clone, we should drastically decrease the number of delete and reclones.I verified that with this, I can get rid of the sleep I had to insert in #5977 to get the new test there to pass, and the test still passes.
Special notes for the reviewer(s)
/assign @pmuir
Which issue this PR fixes
fixes #5976