Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version stream resolver always deletes and reclones for any version ref but a branch #5976

Closed
abayer opened this issue Oct 29, 2019 · 0 comments · Fixed by #5981
Closed

Version stream resolver always deletes and reclones for any version ref but a branch #5976

abayer opened this issue Oct 29, 2019 · 0 comments · Fixed by #5981
Assignees
@abayer
Labels
area/fox area/versions kind/bug Issue is a bug priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
Sprint 17

Comments

@abayer
Copy link
Contributor

abayer commented Oct 29, 2019

This seems to be due to

jx/pkg/versionstream/versionstreamrepo/gitrepo.go

Lines 87 to 89 in bb42263

if versionRef != "" {
remoteRefs = "+refs/heads/" + versionRef + ":refs/remotes/origin/" + versionRef
}
- refs/head/SOME_TAG (or a commit-ish) is always going to fail, so far as I can tell, so deleteAndReclone will keep getting called every time you try to fetch anything but a branch.
@abayer abayer added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Issue is a bug area/versions labels Oct 29, 2019
abayer added a commit to abayer/jx that referenced this issue Oct 29, 2019
@abayer
fix(boot): 'jx upgrade boot' needs to fetch upgrade boot config SHA b…
e9a2e1f 
…efore cherrypicking

Without doing that, the cherry-pick will fail due to the commit from
the release tag not being present in the local boot repo, since it's
not on master.

I had to set a brief sleep between `o.bootConfigRef` calls due to
jenkins-x#5976 causing git to still be
auto-GCing from the first call when it tries to delete and reclone for
the second.

fixes jenkins-x#5974

Signed-off-by: Andrew Bayer <[email protected]>
@abayer abayer mentioned this issue Oct 29, 2019
Merged
2 tasks
abayer added a commit to abayer/jx that referenced this issue Oct 30, 2019
@abayer
fix(versions): Delete and reclone version stream significantly less.
5b47fa9 
By switching to an approach using our `Gitter` APIs rather than the
`go-git` for handling an existing clone, we should drastically
decrease the number of delete and reclones.

fixes jenkins-x#5976

Signed-off-by: Andrew Bayer <[email protected]>
@abayer abayer mentioned this issue Oct 30, 2019
Merged
2 tasks
@abayer abayer self-assigned this Oct 30, 2019
@abayer abayer added this to the Sprint 17 milestone Oct 30, 2019
abayer added a commit to abayer/jx that referenced this issue Oct 30, 2019
@abayer
fix(versions): Delete and reclone version stream significantly less.
2a57332 
By switching to an approach using our `Gitter` APIs rather than the
`go-git` for handling an existing clone, we should drastically
decrease the number of delete and reclones.

fixes jenkins-x#5976

Signed-off-by: Andrew Bayer <[email protected]>
jenkins-x-bot pushed a commit that referenced this issue Oct 30, 2019
@abayer @jenkins-x-bot
fix(versions): Delete and reclone version stream significantly less.
26a62c0 
By switching to an approach using our `Gitter` APIs rather than the
`go-git` for handling an existing clone, we should drastically
decrease the number of delete and reclones.

fixes #5976

Signed-off-by: Andrew Bayer <[email protected]>
daveconde pushed a commit to daveconde/jx that referenced this issue Apr 7, 2020
@abayer
fix(versions): Delete and reclone version stream significantly less.
a4063e9 
By switching to an approach using our `Gitter` APIs rather than the
`go-git` for handling an existing clone, we should drastically
decrease the number of delete and reclones.

fixes jenkins-x#5976

Signed-off-by: Andrew Bayer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abayer abayer

Labels
area/fox area/versions kind/bug Issue is a bug priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
Sprint 17
Development

Successfully merging a pull request may close this issue.

fix(versions): Delete and reclone version stream significantly less. abayer/jx
2 participants
@abayer @deanesmith