Generalize CSP page to document serving user content #4312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-autolabeler
bot
added
the
documentation
MarkEWaite
approved these changes
Apr 30, 2021
|
@daniel-beck I see that you requested a review from @jenkins-infra/security . I assume you want that review before this is merged? If not, I'm happy to merge this. It is a nice improvement. |
I haven't, CODEOWNERS has. I'm confident the content is correct because I wrote the feature (and mostly just copied the content from its docs). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retain the existing page on CSP but replace it in the top-level structure with a more general "Rendering User Content" page that covers primarily the resource root URL.
Changes some of the CSP documentation introduction as it is no longer "standalone". Also, remove the content that made sense when it was new and instead say it's retained only for rare circumstances.
This and #4310 have a slight dependency: Merging this will slightly invalidate the summaries added there, but both can be merged as is and would just need a bit of followup.
Screenshots