-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add generated Jenkins inline help pages #3406
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it rather belongs to a javadoc.jenkins.io-alike service which exposes help pages from Jenkins core and plugins
It looks like the Jenkins core war file is extracted to get the help from core. I assume the same technique would be used for each of the plugins, then their content would be placed in a directory structure that includes the plugin artifact ID in the path to the individual files. Have I understood correctly? How would the URL references be formatter to refer to a specific help file? Would there be additional hierarchy for the help fields based on their location in the plugin jar file? Can we use that location to group multiple help entries for a single item. For example, the git plugin has 163 HTML files, as a sample they look like this:
I guessed that would mean "GitSCM" might be a dedicated page with 15 segments on the page, while GoGS would have 1 and GitLab would have 2. I like the idea of placing it inside jenkins.io more than making it a separate service because I'd rather not have another location to maintain and another location to add to the content delivery network. However, I'm also open to something like https://online-help.jenkins.io/ as a lop level URL. |
This code specifically filters out non-English content. |
Please take a moment and address the merge conflicts of your pull request. Thanks! |
Hi @daniel-beck, is this something that is still being developed, or would it be okay to move this content into a new Issue so that another person could iterate from this? |
@kmartens27 It's unclear what you're asking. Other than fairly straightforward merge conflict resolution, what actions do you expect of me here? |
Hi @daniel-beck, sorry for not being more clear! I was asking to see if there was any further work that needed to be done on this, or if it is just waiting to be merged. There hadn't been any updates since May 2021, and we've been looking at older pull requests that have been marked as "stalled" to try and determine whether they are still being actively worked on, or if they have been abandoned. Would any other actions, besides the merge conflicts, need to be performed? |
There has not been consensus that this PR is a good idea, but neither has it been rejected. |
How do we resolve this? Who all needs to decide whether or not to do this? What would be lost were the merge conflicts resolved and this were merged without conflicts? Does it break some other functionality or would it just add functionality that people could use or not use? |
Many of them are not particularly useful outside the context of Jenkins, but for those it works for it's a lot nicer than linking to files within the GitHub repository.
Thoughts?
Screenshots