Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generated Jenkins inline help pages #3406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daniel-beck
Copy link
Contributor

Many of them are not particularly useful outside the context of Jenkins, but for those it works for it's a lot nicer than linking to files within the GitHub repository.

Thoughts?

Screenshots

index
help

@daniel-beck daniel-beck requested a review from a team as a code owner June 1, 2020 16:54
@probot-autolabeler probot-autolabeler bot added chore documentation Jenkins documentation, including user and developer docs, solution pages, etc. labels Jun 1, 2020
@daniel-beck daniel-beck closed this Jun 1, 2020
@daniel-beck daniel-beck reopened this Jun 1, 2020
Copy link
Contributor

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it rather belongs to a javadoc.jenkins.io-alike service which exposes help pages from Jenkins core and plugins

@oleg-nenashev oleg-nenashev requested review from oleg-nenashev, MarkEWaite, timja and a team July 6, 2020 10:50
@MarkEWaite
Copy link
Contributor

It looks like the Jenkins core war file is extracted to get the help from core. I assume the same technique would be used for each of the plugins, then their content would be placed in a directory structure that includes the plugin artifact ID in the path to the individual files.

Have I understood correctly?

How would the URL references be formatter to refer to a specific help file? Would there be additional hierarchy for the help fields based on their location in the plugin jar file? Can we use that location to group multiple help entries for a single item.

For example, the git plugin has 163 HTML files, as a sample they look like this:

hudson/plugins/git/browser/GogsGit/help-repoUrl.html
hudson/plugins/git/browser/GitLab/help-repoUrl.html
hudson/plugins/git/browser/GitLab/help-version.html
hudson/plugins/git/BranchSpec/help-name_ja.html
hudson/plugins/git/BranchSpec/help-name.html
hudson/plugins/git/ChangelogToBranchOptions/help-compareRemote.html
hudson/plugins/git/ChangelogToBranchOptions/help-compareTarget.html
hudson/plugins/git/ChangelogToBranchOptions/help-compareTarget_ja.html
hudson/plugins/git/ChangelogToBranchOptions/help-compareRemote_ja.html
hudson/plugins/git/UserRemoteConfig/help-refspec.html
hudson/plugins/git/UserRemoteConfig/help-refspec_ja.html
hudson/plugins/git/UserRemoteConfig/help-name_ja.html
hudson/plugins/git/UserRemoteConfig/help-name.html
hudson/plugins/git/UserRemoteConfig/help-url.html
hudson/plugins/git/UserRemoteConfig/help-credentialsId.html
hudson/plugins/git/UserRemoteConfig/help-url_ja.html
hudson/plugins/git/GitSCM/help-choosingStrategy.html
hudson/plugins/git/GitSCM/help-globalConfigName.html
hudson/plugins/git/GitSCM/help-createAccountBasedOnEmail.html
hudson/plugins/git/GitSCM/help-userRemoteConfigs.html
hudson/plugins/git/GitSCM/help-hideCredentials.html
hudson/plugins/git/GitSCM/help-userRemoteConfigs_ja.html
hudson/plugins/git/GitSCM/help-showEntireCommitSummaryInChanges.html
hudson/plugins/git/GitSCM/help-globalConfigEmail.html
hudson/plugins/git/GitSCM/help-gitTool.html
hudson/plugins/git/GitSCM/help-defaultClientType.html
hudson/plugins/git/GitSCM/help-createAccountBasedOnEmail_ja.html
hudson/plugins/git/GitSCM/help-allowSecondFetch.html
hudson/plugins/git/GitSCM/help-globalConfigName_ja.html
hudson/plugins/git/GitSCM/help-globalConfigEmail_ja.html
hudson/plugins/git/GitSCM/help-useExistingAccountWithSameEmail.html

I guessed that would mean "GitSCM" might be a dedicated page with 15 segments on the page, while GoGS would have 1 and GitLab would have 2.

I like the idea of placing it inside jenkins.io more than making it a separate service because I'd rather not have another location to maintain and another location to add to the content delivery network. However, I'm also open to something like https://online-help.jenkins.io/ as a lop level URL.

@daniel-beck
Copy link
Contributor Author

For example, the git plugin has 163 HTML files, as a sample they look like this:

…
hudson/plugins/git/BranchSpec/help-name_ja.html
hudson/plugins/git/BranchSpec/help-name.html

This code specifically filters out non-English content.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 7, 2023

Please take a moment and address the merge conflicts of your pull request. Thanks!

@MarkEWaite MarkEWaite added the stalled Pull requests that are not progressing label Apr 20, 2023
@kmartens27
Copy link
Contributor

Hi @daniel-beck, is this something that is still being developed, or would it be okay to move this content into a new Issue so that another person could iterate from this?

@daniel-beck
Copy link
Contributor Author

@kmartens27 It's unclear what you're asking. Other than fairly straightforward merge conflict resolution, what actions do you expect of me here?

@kmartens27
Copy link
Contributor

Hi @daniel-beck, sorry for not being more clear! I was asking to see if there was any further work that needed to be done on this, or if it is just waiting to be merged. There hadn't been any updates since May 2021, and we've been looking at older pull requests that have been marked as "stalled" to try and determine whether they are still being actively worked on, or if they have been abandoned. Would any other actions, besides the merge conflicts, need to be performed?

@daniel-beck
Copy link
Contributor Author

Would any other actions, besides the merge conflicts, need to be performed?

There has not been consensus that this PR is a good idea, but neither has it been rejected.

@StackScribe
Copy link
Contributor

How do we resolve this? Who all needs to decide whether or not to do this? What would be lost were the merge conflicts resolved and this were merged without conflicts? Does it break some other functionality or would it just add functionality that people could use or not use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore documentation Jenkins documentation, including user and developer docs, solution pages, etc. stalled Pull requests that are not progressing unresolved-merge-conflict There is a merge conflict with the target branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants