-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watched indicator fixes #2998
Watched indicator fixes #2998
Conversation
Uh oh 😭 It's another case of "Works on my machine". Have you pulled all the commits? I just rebased and that should fix your issue as this PR depends on one of my previous PRs which has been merged already. |
Yes I pulled it after your last push. |
Hmm... That's interesting. I guess it's some gitfuckery then as that probably happens due to the code in CardPresenter incorrectly dealing with the watched symbol being on by default when after #2979 it should be off (which is what this PR was made in mind with) |
I think it is actually because you removed the |
Yes, that's correct. As I said, I made the indicators invisible by default, so turning them invisible a second time is unnecessary. |
Once again, the default in the XML will not be magically set when the view is reused in the adapter. You need to make sure that all changes made in the Java code are reverted when the items change. |
Welp, I can only hope that fixes that as I'm unable to replicate the issue :(. Still don't understand why that's happening to you as the default in the XML is set to |
Closing due to inactivity and unsolved review comments. |
Changes
Move indicator logic away from setItem() to setUnwatchedCount() so now there is no need for magic numbers like -1 and everything is generally simpler;
Implement the
HIDE_UNWATCHED
setting;Also fixes the
EPISODES_ONLY
setting;Fixes checkmark not appearing (broken in the .16 betas);
Make the indicator hidden by default. Currently I only enabled it on TV shows, but perhaps I forgot about some other places where they're useful;