-
-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Folder improvements #2979
Folder improvements #2979
Conversation
app/src/main/java/org/jellyfin/androidtv/ui/card/LegacyImageCardView.java
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon looks a lot better on the top-left. It does look like the padding of the text is bigger on the left side compared to the right side though.
So that's a pretty big commit 😅. Here's what changed: Watched indicator changes: Folder card changes: |
That's indeed a big commit. Unfortunately we cannot introduce string changes now if we want to land the changes in the 0.16 release. I'm also not a fan of the unrelated changes you added in the last commits (like changing the behavior of the watch indicator), those things should be in a separate pull request. |
The changed color for folder item count is barely readable when the item doesn't have a dark background. |
Yeah, I can see that being an issue 😅. I'll see what I can do. |
Alright, so in the end I decided to just force some distance between the title and the item count as:
Now the contrast for the counter should be around the same as before the PR while the folder title is actually whiter as I removed the subtle transparency. |
Looks fine now, thanks! |
Changes:
Moved the folder icon to the top left for everything else (Saves space for the name)
Changed purple theme's indicator to match all other themes (Although honestly I prefer the rounded rectangle over the circle, but it was the odd one out)