Switch from a generator to a converter. #29
Conversation
|
Does this work with Jekyll 3.0 also? I get warnings w/ 3.0, and the generated html is completely messed up... |
|
@perlun What warnings and markup are you getting? We're using this here https://github.com/kinesisptyltd/tech.kinesis.org without any problems. |
|
This is what I'm seeing:
The emoji replacement (so that e.g. |
|
(using jemoji 0.5.0) |
|
Confirmed that 0.5.1 works correctly with Jekyll 3. |
|
Sorry thought you meant this PR. 0.5.1 definitely works with 3 and 2. |
| site.pages.each { |doc| emojify doc } | ||
| site.docs_to_write.each { |doc| emojify doc } | ||
| def matches(ext) | ||
| ext == ".html" |
There was a problem hiding this comment.
This doesn't match .md or .textile or any other formats that convert into HTML. :/
There was a problem hiding this comment.
Is there a way to control the order of conveters in Jekyll? Because afacit this happens completely after all other processing and is performed directly on the HTML.
|
Hrm this is trickier than I thought. Only processing the HTML at the end still doesn't fix #12. Keeping this as a generator and going the #28 route will solve #4 (just call the filter in includes) and #5. But #12 will still be an issue and I can't think of a way to solve that without doing what is suggested in that issue and that's creating a |
|
We fixed this in #33 by using Hooks! Thanks 😄 |
This allows us to process HTML rather than just markdown. This removes the need for #28 as it happens after the markdown conversion.
I took the code to deal with code blocks from gjtorikian/html-pipeline#163
Fixes #12
Fixes #5
Fixes #4