Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify include support #4

Closed
benbalter opened this issue Feb 4, 2014 · 5 comments · Fixed by #33
Closed

Verify include support #4

benbalter opened this issue Feb 4, 2014 · 5 comments · Fixed by #33

Comments

@benbalter
Copy link
Contributor

Or implement if needed, possibly via a filter.

/cc @gregose

@benbalter benbalter self-assigned this Feb 4, 2014
@nuclearsandwich
Copy link

Confirmed that includes and layout files do not currently get emoji 😭

@gregose
Copy link
Contributor

gregose commented Feb 5, 2014

If there was a way to subclass and override the default Markdown Convertor we could make a MarkdownEmoji Convertor. Currently it looks like this is preventing any priority of a Convertor from being honored 👿. I would think Jekyll should sort the Convertors matching the filename and take the highest priority.

@parkr
Copy link
Member

parkr commented Feb 5, 2014

@gregose Should be a simple PR if you're interested... 😉

@parkr
Copy link
Member

parkr commented Feb 5, 2014

@benbalter Did you try going through site.layouts? That might strike one of them.

@parkr
Copy link
Member

parkr commented Feb 5, 2014

@gregose Isn't order respected in Enumerable#find? Looks like all we'd have to do is sort them before setting to Convertible.converters

@benbalter benbalter removed their assignment Mar 14, 2014
@jekyll jekyll locked and limited conversation to collaborators Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants