PWA functionality for create-react-app #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Suggest jest-enzyme for simplifying test matchers * Update README.md * Update README.md
* Add SASS support documentation facebook#1007 * Change SASS section title to more generic label * Fix link in Table of Contents * Chain build-css with watch-css script, fix typos * Update Sass and Less naming style * Fix wording, remove offensive words * Slightly rewite
The `test` command fails with multiple arguments when given a unary operator such as '-e'. Add a function that can test one or more files by looping over all files.
* change npm to yarn command * Keep npm primary option
…-app (facebook#1313) * reduxjs/redux#2004 List features beyond ES6 supported by create-react-app * Add more info
* added how to disable autoprefix feature in doc * Just link to the doc
* Tweak syntax doc * Shorter version
* update CSS preprocessor instructions - Windows shell users should note that running two programs simultaneously is not supported. * fix the order of SASS build step - the suggested build step with integrated CSS preprocessing is wrong. The SASS preprocessor should run first, then the react-scripts build will pick the up-to-date final CSS * Add tweaks from PR discussion
* Revert "Don't run CI on Node 0.10" * Install after checking node version * Don't use travis install
* Use Yarn latest in e2e * Here too * And here plz
* Disable require.ensure * Replace require.ensure with import * Add babel plugin for parsing import() * Get the default * Upgrade babel-eslint to support dynamic import * Fix dep * Update deps
* Bump babel deps * Re-enable transform-react-constant-elements Resolves facebook#553
Update links to jest expect function.
* Adding diagnostic code as requested by @gaearon * Oops
Add minify to SWPrecacheWebpackPlugin config / fix readme typos / add more instructions
* fixing things for people with the username `cwd` closes facebook#1694 * combine awk into a single command and add escaping
* Refactor start script into modules * Move dev server config into config file * Replace eject file whitelist with a "remove-file-on-eject" flag * Move utils into scripts folder (for inclusion in ejection) * Add missed changes * Pass showInstructions as an argument * Fix eject bug * Don't eject babelTransform
Remove unused `url` import in Webpack config
* Add docs for apache's client side routing setting * Tweak advice
* Update now.sh deployment instructions. Incorporates changes announced at https://zeit.co/blog/now-static that streamline Now deployments from CRA projects. * Remove unintentional reference to deployed app. No emergency; just didn't intend to tout or send traffic to my prototype.
* updating eslint to 3.16.1 * add support for ignoreRestSiblings in eslint http://eslint.org/docs/rules/no-unused-vars#ignorerestsiblings * updating eslint to 3.16.1 in `react-scripts` * updating eslint * missing `^` * missing ^ * pinning main eslint and updating readme * Pin ESLint version
* add double quotes to escape spaces in path * Change $* to "$@" props to @n3tr * escape spaces in path for all e2e tests
* Fix openBrowser() when BROWSER=open on macOS * Tweaks
* Create empty package.json in e2e test Create empty package.json in e2e test while installing packaged CLI to prevent installation issues. * Use "npm init" to initialize package.json instead of just writing an empty object into it. * Fix typo
* Skip CI builds for Markdown changes * I will never learn YML
* Bump jsx-a11y version * Update package dependecy for jsx-a11y * Bump version in react-scripts
# Conflicts: # packages/react-scripts/config/webpack.config.prod.js
|
Thanks for everyone's feedback! I'm going to move this to a PR against the upstream repo, and will CC: folks who have already participated here in case there is more to add. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will not merge. Just a placeholder PR to solicit feedback.
CC: @ianschmitz @addyosmani