Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump babel deps and re-enable transform-react-constant-elements #1552

Merged
merged 2 commits into from
Feb 15, 2017

Conversation

existentialism
Copy link
Contributor

Fixes #553

@Timer Timer added this to the 0.10.0 milestone Feb 14, 2017
@Timer
Copy link
Contributor

Timer commented Feb 14, 2017

Tagging for 0.10.0 as it may potentially break builds (once out in the wild). Let me know if you want this in 0.9.1, @gaearon.

Thanks for the PR!

@gaearon
Copy link
Contributor

gaearon commented Feb 14, 2017

Let's target 0.10, I agree.

@Timer
Copy link
Contributor

Timer commented Feb 15, 2017

@existentialism: could you please rebase or merge? 😬

@gaearon
Copy link
Contributor

gaearon commented Feb 15, 2017

Tagging as breaking just in case it.. breaks something.

@Timer
Copy link
Contributor

Timer commented Feb 15, 2017

Let's get this in now so people testing against master can uncover any bugs before we cut 0.10.0.

Thanks for being so responsive and on top of this, @existentialism!

@Timer Timer merged commit 9c33f60 into facebook:master Feb 15, 2017
@existentialism existentialism deleted the issue553 branch February 15, 2017 03:09
danielfigueiredo pushed a commit to danielfigueiredo/create-react-app that referenced this pull request Feb 22, 2017
* Bump babel deps

* Re-enable transform-react-constant-elements

Resolves facebook#553
kst404 pushed a commit to kst404/e8e-react-scripts that referenced this pull request Mar 2, 2017
* Bump babel deps

* Re-enable transform-react-constant-elements

Resolves facebook#553
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants