progress: address race conditions in render/stop/trackers; fixes 399#401
Merged
progress: address race conditions in render/stop/trackers; fixes 399#401
Conversation
|
Pull Request Test Coverage Report for Build 20462348615Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes race conditions in the progress package that were caught by the race detector.
The main issues were concurrent access to the output writer and tracker fields without proper synchronization. I've added mutex protection for the output writer and created accessor methods for tracker fields that handle the locking internally. Also fixed a missing mutex protection for the render context cancel call.
I also realized that
make test-racewas only running the progress demo, so I updated it to test all packages to catch these issues earlier.All tests pass with the race detector enabled.
Fixes #399