Skip to content

fix(pipx): combine --pip-args value to avoid argparse error #9982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fru1tworld wants to merge 1 commit into from
+9 −8
Closed

fix(pipx): combine --pip-args value to avoid argparse error #9982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/backend/pipx.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,10 +387,9 @@ impl PIPXBackend {

fn pip_uploaded_prior_to_args(before_date: Option<Timestamp>) -> Vec<OsString> {
match before_date {
Some(before_date) => vec![
"--pip-args".into(),
format!("--uploaded-prior-to={before_date}").into(),
],
Some(before_date) => {
vec![format!("--pip-args=--uploaded-prior-to={before_date}").into()]
}
None => vec![],
}
}
Expand Down Expand Up @@ -898,12 +897,14 @@ mod tests {
let before_date = "2024-01-02T03:04:05Z".parse().unwrap();
let args = PIPXBackend::pip_uploaded_prior_to_args(Some(before_date));

// Combined into a single `--pip-args=VALUE` argv element so pipx's
// argparse doesn't treat the leading `--` of the value as a new flag
// (see discussion #9976).
assert_eq!(
args,
vec![
OsString::from("--pip-args"),
OsString::from("--uploaded-prior-to=2024-01-02T03:04:05Z"),
]
vec![OsString::from(
"--pip-args=--uploaded-prior-to=2024-01-02T03:04:05Z"
)]
);
}

Expand Down
Loading