fix(pipx): combine --pip-args value to avoid argparse error#9982
fix(pipx): combine --pip-args value to avoid argparse error#9982fru1tworld wants to merge 1 commit into
Conversation
Greptile SummaryFixes a regression (#9190) where
Confidence Score: 5/5Minimal, targeted fix with a matching test update — safe to merge. The change is a single-function, single-file edit that corrects an argparse parsing failure. The logic is straightforward, the test is updated to match, and no other callers are affected. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix(pipx): combine --pip-args value to a..." | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review
This pull request updates the PIPXBackend to combine the --pip-args flag and its value into a single argument string. This change ensures that pipx correctly parses the value without misinterpreting its leading dashes as separate flags. The corresponding test case has been updated to reflect this change and includes a comment explaining the rationale. I have no feedback to provide as there were no review comments.
|
This PR has had failing checks for more than 7 days. Feel free to reopen or create a new PR if you'd like to continue working on this. |
Summary
pipx's argparse rejected
--pip-args --uploaded-prior-to=...because the value starts with--. Pack into a single--pip-args=VALUEelement. Regression from #9190.Closes #9976