Skip to content

ci: build/publish snap package for arm64#9948

Merged
jdx merged 3 commits into
jdx:mainfrom
jnsgruk:copilot/update-publish-snapcraft-workflow
May 17, 2026
Merged

ci: build/publish snap package for arm64#9948
jdx merged 3 commits into
jdx:mainfrom
jnsgruk:copilot/update-publish-snapcraft-workflow

Conversation

@jnsgruk

@jnsgruk jnsgruk commented May 17, 2026

Copy link
Copy Markdown
Contributor

Hi there 🙂

I recently tried to install mise using snap on and arm64 desktop and found it wasn't supported. It looks like the snapcraft.yaml already states arm64 as a target architecture, so this change adjusts the publication workflow to run on both amd64 and arm64 runners, in the hope that'll result in publication for arm64.

Copilot AI and others added 2 commits May 17, 2026 20:50
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@greptile-apps

greptile-apps Bot commented May 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR extends the snap publish workflow to build and publish for arm64 in addition to amd64 by introducing a two-entry matrix strategy (ubuntu-24.04 and ubuntu-24.04-arm). It also pins the amd64 runner from ubuntu-latest to ubuntu-24.04 for consistency, adds fail-fast: false so one architecture failure doesn't cancel the other, and adds a top-level permissions: contents: read block.

  • Both runners now build natively for their respective architectures via the snapcore/action-build action, matching the amd64 and arm64 entries in snapcraft.yaml.
  • armhf is declared in snapcraft.yaml but has no corresponding runner in the matrix, so armhf snaps will still not be published (noted in a prior review comment).

Confidence Score: 5/5

This is a safe CI-only change with no impact on application code or release artifacts beyond enabling arm64 snap publication.

The change is confined to a single CI workflow file: it adds a two-entry matrix for native amd64/arm64 builds, pins the runner versions, and sets minimal read permissions. No application logic, credentials handling, or release gating is affected in a risky way.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/snapcraft-publish.yml Adds a matrix strategy to build and publish snaps for both ubuntu-24.04 (amd64) and ubuntu-24.04-arm (arm64); also pins the amd64 runner from ubuntu-latest to ubuntu-24.04 and adds workflow-level read permissions

Reviews (2): Last reviewed commit: "ci: pin snapcraft release workflow to ub..." | Re-trigger Greptile

Comment thread .github/workflows/snapcraft-publish.yml Outdated
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@jdx jdx merged commit 70c2f0b into jdx:main May 17, 2026
33 checks passed
mise-en-dev added a commit that referenced this pull request May 19, 2026
### 🚀 Features

- **(cli)** rename before flag to minimum release age by @risu729 in
[#9768](#9768)
- **(core)** deprecate default package files by @jdx in
[#9970](#9970)
- **(edit)** add --global flag for editing the global config file by
@fru1tworld in [#9953](#9953)

### 🐛 Bug Fixes

- **(aqua)** support cosign public-key bundles by @jdx in
[#9972](#9972)
- **(backend)** pass install_env to postinstall by @risu729 in
[#9930](#9930)
- **(backend)** apply install_env to install commands by @risu729 in
[#9929](#9929)
- **(cargo)** skip binstall for cargo install options by @risu729 in
[#9928](#9928)
- **(config)** restore MISE_ENV_FILE setting by @risu729 in
[#9903](#9903)

### 🚜 Refactor

- **(cli)** use tool wording in version env help by @risu729 in
[#9906](#9906)
- **(conda)** parse tool options locally by @risu729 in
[#9960](#9960)
- **(core)** parse plugin tool options locally by @risu729 in
[#9963](#9963)
- **(go)** parse tool options locally by @risu729 in
[#9961](#9961)
- **(http)** parse tool options locally by @risu729 in
[#9870](#9870)

### 📦️ Dependency Updates

- lock file maintenance by @renovate[bot] in
[#9954](#9954)
- lock file maintenance by @renovate[bot] in
[#9957](#9957)

### 📦 Registry

- use aqua backend for qsv by @risu729 in
[#9910](#9910)

### Ci

- build/publish snap package for arm64 by @jnsgruk in
[#9948](#9948)

### New Contributors

- @jnsgruk made their first contribution in
[#9948](#9948)

## 📦 Aqua Registry Updates

### New Packages (2)

- [`AOMediaCodec/libavif`](https://github.com/AOMediaCodec/libavif)
- [`julian7/redact`](https://github.com/julian7/redact)

### Updated Packages (1)

- [`apache/jena`](https://github.com/apache/jena)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants