fix(backend): apply install_env to install commands#9929
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces the install_env tool option across all mise backends, allowing users to specify environment variables for tool installation and build processes. The update includes comprehensive documentation for each backend and a new E2E test. Feedback indicates that the precedence of environment variables needs adjustment in several plugins: critical mise-managed variables (e.g., RUSTUP_TOOLCHAIN, DOTNET_ROOT, PIP_REQUIRE_VIRTUALENV) should be protected from user overrides to prevent corrupted installations, whereas user-defined variables should be allowed to override non-critical defaults like MAKEFLAGS or global CFLAGS.
Greptile SummaryThis PR propagates the per-tool
Confidence Score: 5/5Safe to merge; the change is additive with no control-flow changes outside the deliberate node.rs borrow-checker refactor, which is logically equivalent to the original. Every modified command site follows a consistent, reviewed ordering pattern. The structural refactor in node.rs preserves identical semantics. The vfox and pipx changes carry incidental correctness improvements. Previously discussed ordering trade-offs are acknowledged and intentional. No files require special attention beyond what was already discussed in prior review threads. Important Files Changed
Reviews (5): Last reviewed commit: "fix(backend): remove dead cargo feature ..." | Re-trigger Greptile |
48938ed to
75037f2
Compare
Add 'locked' field to usage-cli configuration
70dc752 to
b9301f7
Compare
### 🚀 Features - **(cli)** rename before flag to minimum release age by @risu729 in [#9768](#9768) - **(core)** deprecate default package files by @jdx in [#9970](#9970) - **(edit)** add --global flag for editing the global config file by @fru1tworld in [#9953](#9953) ### 🐛 Bug Fixes - **(aqua)** support cosign public-key bundles by @jdx in [#9972](#9972) - **(backend)** pass install_env to postinstall by @risu729 in [#9930](#9930) - **(backend)** apply install_env to install commands by @risu729 in [#9929](#9929) - **(cargo)** skip binstall for cargo install options by @risu729 in [#9928](#9928) - **(config)** restore MISE_ENV_FILE setting by @risu729 in [#9903](#9903) ### 🚜 Refactor - **(cli)** use tool wording in version env help by @risu729 in [#9906](#9906) - **(conda)** parse tool options locally by @risu729 in [#9960](#9960) - **(core)** parse plugin tool options locally by @risu729 in [#9963](#9963) - **(go)** parse tool options locally by @risu729 in [#9961](#9961) - **(http)** parse tool options locally by @risu729 in [#9870](#9870) ### 📦️ Dependency Updates - lock file maintenance by @renovate[bot] in [#9954](#9954) - lock file maintenance by @renovate[bot] in [#9957](#9957) ### 📦 Registry - use aqua backend for qsv by @risu729 in [#9910](#9910) ### Ci - build/publish snap package for arm64 by @jnsgruk in [#9948](#9948) ### New Contributors - @jnsgruk made their first contribution in [#9948](#9948) ## 📦 Aqua Registry Updates ### New Packages (2) - [`AOMediaCodec/libavif`](https://github.com/AOMediaCodec/libavif) - [`julian7/redact`](https://github.com/julian7/redact) ### Updated Packages (1) - [`apache/jena`](https://github.com/apache/jena)
Summary
Project item: https://github.com/users/risu729/projects/3/views/1?filterQuery=install_env&pane=issue&itemId=188373493
Tests