fix(backend): date-check latest stable fast path#9650
Conversation
Greptile SummaryThis PR changes the
Confidence Score: 5/5Safe to merge — the cutoff logic is conservative and the cache reuse is correct. The fast-path change is well-bounded: No files require special attention. Important Files Changed
Reviews (3): Last reviewed commit: "fix(backend): verify latest stable cutof..." | Re-trigger Greptile |
There was a problem hiding this comment.
Code Review
This PR refactors the 'latest' version resolution to allow backends to use fast-path results even when date cutoffs are active, provided the candidate meets the date criteria. The Aqua backend was updated to support this by fetching the latest GitHub release, and helper functions were added for tag parsing and asset validation. E2E tests were also adjusted to verify cache reuse and fallback logic. A review comment identifies a potential performance bottleneck in the Aqua backend where package objects are cloned repeatedly within a loop.
|
CI note after the latest push: all non-Windows-e2e checks have completed successfully or skipped as expected. The only failures are:
This stacked PR does not touch the Windows Zig test or that download host. This comment was generated by an AI coding assistant. |
94fd136 to
8d593a3
Compare
### 🚀 Features - **(cli)** add minimum release age flag to lock and ls-remote by @risu729 in [#9269](#9269) - **(config)** add run field for hooks by @risu729 in [#9718](#9718) - **(github)** add native oauth token source by @jdx in [#9654](#9654) - **(oci)** scope build to project config by default by @jdx in [#9766](#9766) - add support for prefixed latest version queries in outdated checks by @roele in [#9767](#9767) ### 🐛 Bug Fixes - **(activate)** guard bash chpwd hook under nounset by @risu729 in [#9716](#9716) - **(backend)** date-check latest stable fast path by @risu729 in [#9650](#9650) - **(config)** parse core tool options consistently by @risu729 in [#9742](#9742) - **(exec)** propagate __MISE_DIFF so nested mise recovers pristine PATH by @jdx in [#9765](#9765) - **(forgejo)** include prereleases when opted in by @risu729 in [#9717](#9717) - **(github)** avoid caching empty release assets by @risu729 in [#9616](#9616) - **(java)** resolve lockfile URLs from metadata by @risu729 in [#9719](#9719) - **(lock)** cache unavailable github attestations by @risu729 in [#9741](#9741) - **(pipx)** preserve options when reinstalling tools by @risu729 in [#9663](#9663) - **(python)** skip redundant lockfile provenance verification by @risu729 in [#9739](#9739) - **(vfox)** run pre_uninstall hook by @risu729 in [#9662](#9662) ### 🚜 Refactor - **(schema)** extract tool options definition by @risu729 in [#9649](#9649) ### ⚡ Performance - **(aqua)** bake rkyv aqua package blobs by @risu729 in [#9535](#9535) ### 📦️ Dependency Updates - lock file maintenance by @renovate[bot] in [#9773](#9773) ### 📦 Registry - add vector ([github:vectordotdev/vector](https://github.com/vectordotdev/vector)) by @kquinsland in [#9761](#9761) - add oc and openshift-install (http backend) by @konono in [#9669](#9669) ### New Contributors - @konono made their first contribution in [#9669](#9669) - @kquinsland made their first contribution in [#9761](#9761)
Summary
latest_stable_versionfast path forlatestrequests even when--beforeorminimum_release_ageis activeValidation
cargo fmt --checkgit diff --check upstream/main..HEADenv RUSTC_WRAPPER= cargo test latest_version_tests -- --nocaptureThis PR was generated by an AI coding assistant.