refactor(schema): extract tool options definition

[risu729]

Why

#9582 restored the schema pattern we wanted for task objects: shared property definitions composed with allOf, then closed with unevaluatedProperties. With Tombi pinned to a version that handles evaluated properties correctly, we can use the same pattern for tool option objects.

The top-level [tools] schema and task tools schema both describe the same { version, os } object shape, but with different extra-property rules. Duplicating the common part makes it easy for those two locations to drift. This PR extracts the shared version/os piece and lets each call site keep its own closure behavior.

What changed

• Adds a shared $defs.tool_options schema for the common version and os fields.
• Reuses it from both top-level tool options and task tool options.
• Preserves the important difference between call sites: root tool objects still allow backend-specific values, while task tool objects still only allow string extras.
• Extends the Tombi regression test so warnings fail and the shared-schema behavior is covered.

Validation

• git diff --check
• Direct Tombi validation with tombi@0.9.22 and --error-on-warnings for valid root/task tool options and invalid task tool extra options.
• Full e2e should run in CI; my earlier local targeted e2e run was stopped after the build step stalled behind another active cargo build on this machine.

This PR was generated by an AI coding assistant.

[gemini-code-assist]

Code Review

This pull request updates the project's JSON schemas and the schema generation script to use "unevaluatedProperties": false instead of "additionalProperties": false. This refactoring allows for better property sharing via $refs in task definitions, leveraging improvements in Tombi v0.9.19+. The E2E tests have been updated to use a pinned Tombi version and include new test cases for validating nested properties like backend_options and profile. I have no feedback to provide as there were no review comments.

[greptile-apps]

Greptile Summary

This PR extracts the shared version/os tool options into a reusable $defs/tool_options definition, replacing duplicated inline properties in both mise.json and mise-task.json with allOf + $ref composition and migrating from additionalProperties to unevaluatedProperties for correct JSON Schema 2019-09+ $ref evaluation.

• Schema refactoring: tool_options is now a single shared $defs entry; root tool objects use allOf with tool_options plus their install_env/depends/postinstall-specific properties, while task tool objects use a single-entry allOf. Both use unevaluatedProperties rather than additionalProperties.
• Intentional schema expansion for root tools: The unevaluatedProperties for top-level [tools] entries now permits array and object extra-property types in addition to the previous string|number|boolean — enabling backend-specific nested config like backend_options = { nested = true }. This is validated by the updated mise-os.toml fixture, but the PR description's claim of "existing extra-property behavior is preserved" is slightly misleading given this widening.
• Improved e2e coverage: --error-on-warnings is added to all tombi lint calls, and a new mise-bad-task-tool-extra.toml fixture asserts that object-valued extras are correctly rejected for task tools.

Confidence Score: 5/5

Safe to merge — a structural schema refactoring with deliberately expanded root-tool permissiveness that is covered by explicit tests.

The refactoring is logically consistent across both schema files: unevaluatedProperties correctly inherits evaluated properties from $ref targets under allOf, required: ["version"] inside tool_options propagates through the composition, and the task-tool path still rejects non-string extras as before. The only substantive behavior change — allowing array/object backend extras on root tools — is intentional and validated by the updated e2e fixtures. No schema constraints are accidentally dropped or inverted.

No files require special attention. The schema files are consistent with each other and the test script fully covers the new permissiveness boundaries.

_{Reviews (3): Last reviewed commit: "[autofix.ci] apply automated fixes" | Re-trigger Greptile}

[risu729]

Greptile note on the root tool extra-property types looks stale against the actual stack/current main. upstream/main:schema/mise.json already allows string | number | boolean | array | object for root tool extra properties; this PR preserves that set by moving the same schema under unevaluatedProperties around the new $defs.tool_options ref. No code change needed.

This comment was generated by an AI coding assistant.