feat(asset-matcher): enable mingw-w64 detection for windows packages

[lchagnoleau]

mingw-w64 should be considered as windows compatible packages.

For example, arm-none-eabi toolchain for windows is:
arm-gnu-toolchain-15.2.rel1-mingw-w64-i686-arm-none-eabi.zip

[gemini-code-assist]

Summary of Changes

Hello @lchagnoleau, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the asset matching capabilities by integrating mingw-w64 into the Windows operating system detection logic. This change ensures that packages explicitly labeled with mingw-w64 in their filenames are correctly identified as Windows-compatible, thereby broadening the range of discoverable assets for Windows users and improving the overall reliability of the asset picker.

Highlights

• Enhanced Windows Asset Detection: The asset matching logic has been updated to recognize mingw-w64 as a valid identifier for Windows-compatible packages, improving the accuracy of asset selection for Windows environments.
• Regex Pattern Update: The regular expression used to identify Windows operating systems in asset names (OS_PATTERNS) was modified to explicitly include mingw-w64.
• Test Case Refinement: Existing test cases were adjusted to reflect the new mingw-w64 naming convention for Windows assets, and a new assertion was added to confirm correct asset picking for mingw-w64 packages on Windows.

Changelog

• src/backend/asset_matcher.rs
  • Updated the OS_PATTERNS regex for AssetOs::Windows to include mingw-w64.
  • Modified a test asset name from tool-1.0.0-windows-x86_64.zip to tool-1.0.0-mingw-w64-x86_64.zip.
  • Added a new test assertion to confirm that the AssetPicker correctly selects mingw-w64 assets for Windows.

Activity

• No human activity (comments, reviews, etc.) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for detecting mingw-w64 as a Windows-compatible package. The change to the OS detection regex is a good addition, but it has a flaw that could lead to false positives. I've added a comment with a suggested fix for the regex. The test changes look good and correctly validate the new functionality.