Skip to content

feat(crates/vfox): add download_path to BackendInstall context#7959

Merged
jdx merged 2 commits into
jdx:mainfrom
malept:feat/vfox-backend-install-download-path
Feb 2, 2026
Merged

feat(crates/vfox): add download_path to BackendInstall context#7959
jdx merged 2 commits into
jdx:mainfrom
malept:feat/vfox-backend-install-download-path

Conversation

@malept

@malept malept commented Feb 2, 2026

Copy link
Copy Markdown
Contributor

Allow backend plugins to use the standard configured location to download artifacts.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @malept, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the vfox system by providing backend plugins with a dedicated and configurable download_path within the BackendInstallContext. This change allows plugins to consistently store downloaded artifacts in a standard location, improving organization and adherence to system configurations during the installation of tools.

Highlights

  • Feature: download_path in BackendInstallContext: Introduced a new download_path field to the BackendInstallContext struct, providing backend plugins with a standardized location for downloading artifacts.
  • Lua Plugin Accessibility: The download_path is now exposed to Lua-based backend plugins through the IntoLua implementation for BackendInstallContext, allowing them to utilize this path.
  • Core and Backend Integration: Updated the vfox core and its backend implementation to correctly pass the new download_path during the backend_install process.
  • Documentation Update: The backend-plugin-development.md documentation has been updated to reflect the addition of ctx.download_path in the BackendInstall Context, including its description and an example.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly adds the download_path to the BackendInstall context, allowing vfox backend plugins to access the standard download location. The changes are well-implemented across the struct definition, Lua conversion, function calls, and documentation. I've identified a minor inconsistency in the documentation example for install_path which should be corrected for clarity.

Comment thread docs/backend-plugin-development.md Outdated
@jdx jdx merged commit f00d24e into jdx:main Feb 2, 2026
35 checks passed
@malept malept deleted the feat/vfox-backend-install-download-path branch February 2, 2026 16:02
jdx pushed a commit that referenced this pull request Feb 3, 2026
#7973)

Missed due to a PR race condition (#7961 was created after #7959).

Also updates the lockfile for `stylua`.
mise-en-dev added a commit that referenced this pull request Feb 3, 2026
### 🚀 Features

- **(asset-matcher)** enable `mingw-w64` detection for windows packages
by @lchagnoleau in [#7981](#7981)
- **(crates/vfox)** add download_path to BackendInstall context by
@malept in [#7959](#7959)
- **(python)** rework `python.uv_venv_auto` setting by @halms in
[#7905](#7905)
- add "Did you mean?" suggestions and inactive tool warnings by @jdx in
[#7965](#7965)

### 🐛 Bug Fixes

- **(hook-env)** skip remote version fetching for uninstalled tools in
prefer-offline mode by @jdx in
[#7976](#7976)
- **(install.sh)** Corret `setup` to `set up` by @gogolok in
[#7980](#7980)
- retry spawn on ETXTBSY (Text file busy) by @jdx in
[#7964](#7964)
- improve ToolOptions parsing to support comma separated values by
@roele in [#7971](#7971)

### 📚 Documentation

- improve plugin documentation with comparisons and template links by
@jdx in [#7962](#7962)

### 📦️ Dependency Updates

- bump hyper-util, system-configuration, lru, aws-sdk, and others by
@jdx in [#7977](#7977)

### Chore

- **(vfox)** add LuaCATS type definitions for plugin IDE support by @jdx
in [#7961](#7961)
- **(vfox)** add `download_path` to `BackendInstallCtx` type defintion
by @malept in [#7973](#7973)
- add stylua linting for vfox plugin Lua files by @jdx in
[#7960](#7960)
- use system Rust for PPA builds on Ubuntu 26.04+ by @jdx in
[#7956](#7956)

### New Contributors

- @gogolok made their first contribution in
[#7980](#7980)

## 📦 Aqua Registry Updates

#### New Packages (4)

- [`autobrr/mkbrr`](https://github.com/autobrr/mkbrr)
- [`dodobrands/Peekie`](https://github.com/dodobrands/Peekie)
-
[`grpc/grpc-java/protoc-gen-grpc-java`](https://github.com/grpc/grpc-java/protoc-gen-grpc-java)
-
[`str4d/age-plugin-yubikey`](https://github.com/str4d/age-plugin-yubikey)

#### Updated Packages (3)

- [`biomejs/biome`](https://github.com/biomejs/biome)
-
[`rust-cross/cargo-zigbuild`](https://github.com/rust-cross/cargo-zigbuild)
- [`siderolabs/talos`](https://github.com/siderolabs/talos)
lucasew pushed a commit to lucasew/CONTRIB-mise that referenced this pull request Feb 18, 2026
)

Allow backend plugins to use the standard configured location to
download artifacts.
lucasew pushed a commit to lucasew/CONTRIB-mise that referenced this pull request Feb 18, 2026
jdx#7973)

Missed due to a PR race condition (jdx#7961 was created after jdx#7959).

Also updates the lockfile for `stylua`.
lucasew pushed a commit to lucasew/CONTRIB-mise that referenced this pull request Feb 18, 2026
### 🚀 Features

- **(asset-matcher)** enable `mingw-w64` detection for windows packages
by @lchagnoleau in [jdx#7981](jdx#7981)
- **(crates/vfox)** add download_path to BackendInstall context by
@malept in [jdx#7959](jdx#7959)
- **(python)** rework `python.uv_venv_auto` setting by @halms in
[jdx#7905](jdx#7905)
- add "Did you mean?" suggestions and inactive tool warnings by @jdx in
[jdx#7965](jdx#7965)

### 🐛 Bug Fixes

- **(hook-env)** skip remote version fetching for uninstalled tools in
prefer-offline mode by @jdx in
[jdx#7976](jdx#7976)
- **(install.sh)** Corret `setup` to `set up` by @gogolok in
[jdx#7980](jdx#7980)
- retry spawn on ETXTBSY (Text file busy) by @jdx in
[jdx#7964](jdx#7964)
- improve ToolOptions parsing to support comma separated values by
@roele in [jdx#7971](jdx#7971)

### 📚 Documentation

- improve plugin documentation with comparisons and template links by
@jdx in [jdx#7962](jdx#7962)

### 📦️ Dependency Updates

- bump hyper-util, system-configuration, lru, aws-sdk, and others by
@jdx in [jdx#7977](jdx#7977)

### Chore

- **(vfox)** add LuaCATS type definitions for plugin IDE support by @jdx
in [jdx#7961](jdx#7961)
- **(vfox)** add `download_path` to `BackendInstallCtx` type defintion
by @malept in [jdx#7973](jdx#7973)
- add stylua linting for vfox plugin Lua files by @jdx in
[jdx#7960](jdx#7960)
- use system Rust for PPA builds on Ubuntu 26.04+ by @jdx in
[jdx#7956](jdx#7956)

### New Contributors

- @gogolok made their first contribution in
[jdx#7980](jdx#7980)

## 📦 Aqua Registry Updates

#### New Packages (4)

- [`autobrr/mkbrr`](https://github.com/autobrr/mkbrr)
- [`dodobrands/Peekie`](https://github.com/dodobrands/Peekie)
-
[`grpc/grpc-java/protoc-gen-grpc-java`](https://github.com/grpc/grpc-java/protoc-gen-grpc-java)
-
[`str4d/age-plugin-yubikey`](https://github.com/str4d/age-plugin-yubikey)

#### Updated Packages (3)

- [`biomejs/biome`](https://github.com/biomejs/biome)
-
[`rust-cross/cargo-zigbuild`](https://github.com/rust-cross/cargo-zigbuild)
- [`siderolabs/talos`](https://github.com/siderolabs/talos)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants